Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: chrome/browser/ui/webui/signin/inline_login_handler.cc

Issue 134733019: Add perf histogram and tests for inline signin (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/signin/inline_login_handler.h" 5 #include "chrome/browser/ui/webui/signin/inline_login_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/metrics/histogram.h"
8 #include "base/values.h" 9 #include "base/values.h"
9 #include "chrome/browser/browser_process.h" 10 #include "chrome/browser/browser_process.h"
11 #include "chrome/browser/signin/signin_promo.h"
12 #include "content/public/browser/web_contents.h"
10 #include "content/public/browser/web_ui.h" 13 #include "content/public/browser/web_ui.h"
11 #include "google_apis/gaia/gaia_urls.h" 14 #include "google_apis/gaia/gaia_urls.h"
12 15
13 InlineLoginHandler::InlineLoginHandler() {} 16 InlineLoginHandler::InlineLoginHandler()
17 : load_start_time_(base::Time::Now()) {}
14 18
15 InlineLoginHandler::~InlineLoginHandler() {} 19 InlineLoginHandler::~InlineLoginHandler() {}
16 20
17 void InlineLoginHandler::RegisterMessages() { 21 void InlineLoginHandler::RegisterMessages() {
18 web_ui()->RegisterMessageCallback("initialize", 22 web_ui()->RegisterMessageCallback("initialize",
19 base::Bind(&InlineLoginHandler::HandleInitializeMessage, 23 base::Bind(&InlineLoginHandler::HandleInitializeMessage,
20 base::Unretained(this))); 24 base::Unretained(this)));
25 web_ui()->RegisterMessageCallback("loginUIInitialized",
26 base::Bind(&InlineLoginHandler::HandleLoginUIInitializedMessage,
27 base::Unretained(this)));
21 web_ui()->RegisterMessageCallback("completeLogin", 28 web_ui()->RegisterMessageCallback("completeLogin",
22 base::Bind(&InlineLoginHandler::HandleCompleteLoginMessage, 29 base::Bind(&InlineLoginHandler::HandleCompleteLoginMessage,
23 base::Unretained(this))); 30 base::Unretained(this)));
24 } 31 }
25 32
26 void InlineLoginHandler::HandleInitializeMessage(const base::ListValue* args) { 33 void InlineLoginHandler::HandleInitializeMessage(const base::ListValue* args) {
27 base::DictionaryValue params; 34 base::DictionaryValue params;
28 35
29 const std::string& app_locale = g_browser_process->GetApplicationLocale(); 36 const std::string& app_locale = g_browser_process->GetApplicationLocale();
30 params.SetString("hl", app_locale); 37 params.SetString("hl", app_locale);
31 GaiaUrls* gaiaUrls = GaiaUrls::GetInstance(); 38 GaiaUrls* gaiaUrls = GaiaUrls::GetInstance();
32 params.SetString("gaiaUrl", gaiaUrls->gaia_url().spec()); 39 params.SetString("gaiaUrl", gaiaUrls->gaia_url().spec());
33 params.SetInteger("authMode", kDefaultAuthMode); 40 params.SetInteger("authMode", kDefaultAuthMode);
34 41
35 SetExtraInitParams(params); 42 SetExtraInitParams(params);
36 43
37 web_ui()->CallJavascriptFunction("inline.login.loadAuthExtension", params); 44 web_ui()->CallJavascriptFunction("inline.login.loadAuthExtension", params);
38 } 45 }
39 46
47 void InlineLoginHandler::HandleLoginUIInitializedMessage(
48 const base::ListValue* args) {
49 if (load_start_time_.is_max())
50 return;
51
52 double gaia_start_time_str;
53 double gaia_stop_time_str;
54 CHECK(args->GetDouble(0, &gaia_start_time_str));
55 CHECK(args->GetDouble(1, &gaia_stop_time_str));
56
57 const GURL& current_url = web_ui()->GetWebContents()->GetURL();
58 signin::Source source = signin::GetSourceForPromoURL(current_url);
59 const std::string& prefix = source == signin::SOURCE_START_PAGE ?
60 "Signin.InlineUI.LoadOnStartup." :
61 "Signin.InlineUI.LoadAfterStartup.";
62
63 const base::Time gaia_start_time(base::Time::FromJsTime(gaia_start_time_str));
64 UMA_HISTOGRAM_MEDIUM_TIMES(
65 prefix + "PreGaiaLoadTime", gaia_start_time - load_start_time_);
66 UMA_HISTOGRAM_MEDIUM_TIMES(
67 prefix + "GaiaLoadTime",
68 base::Time::FromJsTime(gaia_stop_time_str) - gaia_start_time);
69 load_start_time_ = base::Time::Max();
70 }
71
40 void InlineLoginHandler::HandleCompleteLoginMessage( 72 void InlineLoginHandler::HandleCompleteLoginMessage(
41 const base::ListValue* args) { 73 const base::ListValue* args) {
42 CompleteLogin(args); 74 CompleteLogin(args);
43 } 75 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698