Source/platform/graphics/filters/FilterEffect.h - Issue 134733016: Add support for converting Colors to linear RGB; Fix relevant filters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/filters/FilterEffect.h

Issue 134733016: Add support for converting Colors to linear RGB; Fix relevant filters (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/graphics/ColorSpace.h ('K') | « Source/platform/graphics/filters/FELighting.cpp ('k') | Source/platform/graphics/filters/FilterEffect.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/filters/FilterEffect.h

diff --git a/Source/platform/graphics/filters/FilterEffect.h b/Source/platform/graphics/filters/FilterEffect.h

index e582fc0895729234ac37a5c7710229671235a3d8..8e4c351797b89e23242f9b4739f65183519eb87e 100644

--- a/Source/platform/graphics/filters/FilterEffect.h

+++ b/Source/platform/graphics/filters/FilterEffect.h

@@ -26,6 +26,7 @@

#include "platform/PlatformExport.h"

#include "platform/geometry/FloatRect.h"

#include "platform/geometry/IntRect.h"

+#include "platform/graphics/Color.h"

#include "platform/graphics/ColorSpace.h"

#include "third_party/skia/include/core/SkImageFilter.h"

@@ -183,6 +184,8 @@ protected:

Uint8ClampedArray* createUnmultipliedImageResult();

Uint8ClampedArray* createPremultipliedImageResult();

+ Color adaptColorToOperatingColorSpace(const Color& deviceColor);

Stephen Chennney 2014/01/22 14:56:01 This is the method that could be used in more plac

// Return true if the filter will only operate correctly on valid RGBA values, with

// alpha in [0,255] and each color component in [0, alpha].

virtual bool requiresValidPreMultipliedPixels() { return true; }

« Source/platform/graphics/ColorSpace.h ('K') | « Source/platform/graphics/filters/FELighting.cpp ('k') | Source/platform/graphics/filters/FilterEffect.cpp » ('j') | no next file with comments »