Issue 134733011: Don't overwrite transitions in SetPropertyIgnoreAttributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 134733011: Don't overwrite transitions in SetPropertyIgnoreAttributes. (Closed)

Created:
6 years, 11 months ago by Toon Verwaest

Modified:
6 years, 11 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Ensure we don't overwrite transitions in SetPropertyIgnoreAttributes. BUG=326155 LOG=y R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18754

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -1 line)			Patch
M	src/objects.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Jakob Kummerow

LGTM if you add a regression test that hits the ASSERT without the fix applied.

6 years, 11 months ago (2014-01-21 19:48:41 UTC) #2

Toon Verwaest

6 years, 11 months ago (2014-01-22 14:02:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r18754 (presubmit successful).