Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1347313002: Don't merge adjacent composition markers. (Closed)

Created:
5 years, 3 months ago by aelias_OOO_until_Jul13
Modified:
5 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't merge adjacent composition markers. In CJK text compositions, a common pattern is for multiple adjacent segments to be underlined, with a small separation between each and possibly a thickness difference (example appearance at http://www.w3.org/TR/ime-api/images/image08.png). DocumentMarkerController's default behavior to merge overlapping or adjacent markers converted this to a single uniform line, so disable the merging for composition markers. TEST=webkit_unit_tests --gtest_filter=DocumentMarkerControllerTest.CompositionMarkersNotMerged BUG=488628 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202423

Patch Set 1 #

Patch Set 2 : Remove unnecessary toElement() call in the unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M Source/core/editing/markers/DocumentMarkerController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/markers/DocumentMarkerControllerTest.cpp View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
aelias_OOO_until_Jul13
Hi yosin@, I noticed this regression introduced by my previous patch today while playing around ...
5 years, 3 months ago (2015-09-17 00:27:59 UTC) #2
yosin_UTC9
lgtm Thanks for fixing!
5 years, 3 months ago (2015-09-17 01:51:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347313002/1
5 years, 3 months ago (2015-09-17 01:51:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347313002/20001
5 years, 3 months ago (2015-09-17 02:27:03 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 03:31:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202423

Powered by Google App Engine
This is Rietveld 408576698