chrome/common/extensions/extension.h - Issue 13473013: Move ThemeHandler from c/c/e/api; move GetBrowserImages() out of Extension class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension.h

Issue 13473013: Move ThemeHandler from c/c/e/api; move GetBrowserImages() out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Latest master (+blink) Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/themes/theme_handler.cc ('k') | chrome/common/extensions/extension.cc » ('j') | chrome/common/extensions/extension_file_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension.h

diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h

index 0ab8b4e9956e2c0be3c746895f1e81154ffbae97..aeafc3ecfaeab469eeae9a3a5d0cc079349235d0 100644

--- a/chrome/common/extensions/extension.h

+++ b/chrome/common/extensions/extension.h

@@ -309,10 +309,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {

// Whether context menu should be shown for page and browser actions.

bool ShowConfigureContextMenus() const;

- // Returns a list of paths (relative to the extension dir) for images that

- // the browser might load (like themes and page action icons).

- std::set<base::FilePath> GetBrowserImages() const;

// Gets the fully resolved absolute launch URL.

GURL GetFullLaunchURL() const;