content/renderer/accessibility/renderer_accessibility.cc - Issue 1347243005: Make selection changes in a text field invalidate accessibility tree root.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/renderer_accessibility.cc

Issue 1347243005: Make selection changes in a text field invalidate accessibility tree root. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable RendererAccessibilityTest.TextSelectionShouldSendRoot for Android; all other tests in this … Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/android/pylib/gtest/filter/content_browsertests_disabled ('k') | content/renderer/accessibility/renderer_accessibility_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility/renderer_accessibility.cc

diff --git a/content/renderer/accessibility/renderer_accessibility.cc b/content/renderer/accessibility/renderer_accessibility.cc

index 5846b9a58f38e8ac03176b7aa5af2beab9a530c8..812af620fca0a7fe15f92977ab3117e9351f41d8 100644

--- a/content/renderer/accessibility/renderer_accessibility.cc

+++ b/content/renderer/accessibility/renderer_accessibility.cc

@@ -186,6 +186,15 @@ void RendererAccessibility::HandleAXEvent(

}

+ if (event == ui::AX_EVENT_TEXT_SELECTION_CHANGED &&

+ obj.isFocused() &&

+ !obj.equals(document.accessibilityObject())) {

+ // Changing the text selection in a text field may invalidate

+ // the anchor/focus attributes on the tree root. Send a generic

+ // notification to have it updated.

+ HandleAXEvent(document.accessibilityObject(), event);

+ }

// Add the accessibility object to our cache and ensure it's valid.

AccessibilityHostMsg_EventParams acc_event;

acc_event.id = obj.axID();