Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: src/runtime/runtime-classes.cc

Issue 1347243004: [strong] Implement revised strong class semantics (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: \cl feedback Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/strong/class-literals.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime/runtime-classes.cc
diff --git a/src/runtime/runtime-classes.cc b/src/runtime/runtime-classes.cc
index 5f098148664ff86253602185809b89e27becb2a0..3ef6c99351d0b3d00c28b9879746e0362d55ecad 100644
--- a/src/runtime/runtime-classes.cc
+++ b/src/runtime/runtime-classes.cc
@@ -142,13 +142,6 @@ static MaybeHandle<Object> DefineClass(Isolate* isolate, Handle<Object> name,
THROW_NEW_ERROR(isolate, NewTypeError(MessageTemplate::kStrongExtendNull),
Object);
}
- } else {
- if (Handle<HeapObject>::cast(super_class)->map()->is_strong()) {
- // Weak class is not permitted to extend strong class.
- THROW_NEW_ERROR(isolate,
- NewTypeError(MessageTemplate::kStrongWeakExtend, name),
- Object);
- }
}
Map::SetPrototype(map, prototype_parent);
map->SetConstructor(*constructor);
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/strong/class-literals.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698