Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1347243004: [strong] Implement revised strong class semantics (Closed)

Created:
5 years, 3 months ago by conradw
Modified:
5 years, 3 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Implement revised strong class semantics Weak classes can inherit from strong ones again, a strong base class makes instances strong. BUG=v8:3956 LOG=N Committed: https://crrev.com/24ec2a0baae57dc9f6e1dfce7c5bdf30ea8c791d Cr-Commit-Position: refs/heads/master@{#30867}

Patch Set 1 #

Total comments: 1

Patch Set 2 : \cl feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -92 lines) Patch
M src/messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.cc View 3 chunks +8 lines, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +0 lines, -7 lines 0 comments Download
A test/mjsunit/strong/class-literals.js View 1 1 chunk +159 lines, -0 lines 0 comments Download
M test/mjsunit/strong/class-object-frozen.js View 1 chunk +17 lines, -0 lines 0 comments Download
D test/mjsunit/strong/class-weak-extend.js View 1 chunk +0 lines, -28 lines 0 comments Download
M test/mjsunit/strong/literals.js View 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
conradw
PTAL
5 years, 3 months ago (2015-09-17 14:16:11 UTC) #2
rossberg
lgtm LGTM modulo comment https://codereview.chromium.org/1347243004/diff/1/test/mjsunit/strong/class-literals.js File test/mjsunit/strong/class-literals.js (right): https://codereview.chromium.org/1347243004/diff/1/test/mjsunit/strong/class-literals.js#newcode118 test/mjsunit/strong/class-literals.js:118: (function MonkeyPatchedClassLiterals() { Maybe add ...
5 years, 3 months ago (2015-09-22 15:26:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347243004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347243004/20001
5 years, 3 months ago (2015-09-22 16:30:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-22 16:34:47 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 16:35:06 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24ec2a0baae57dc9f6e1dfce7c5bdf30ea8c791d
Cr-Commit-Position: refs/heads/master@{#30867}

Powered by Google App Engine
This is Rietveld 408576698