Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 134723004: Prevent parallelization of ash browsertests on the same machine. (Closed)

Created:
6 years, 11 months ago by gab
Modified:
6 years, 11 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Prevent parallelization of ash browsertests on the same machine. BUG=286205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M scripts/master/factory/chromium_factory.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
gab
As you suggested on the bug. I'm not familiar at all with these configs, do ...
6 years, 11 months ago (2014-01-10 22:26:29 UTC) #1
gab
On 2014/01/10 22:26:29, gab wrote: > As you suggested on the bug. > > I'm ...
6 years, 11 months ago (2014-01-13 17:02:05 UTC) #2
Paweł Hajdan Jr.
Hey Gabriel, yes this would require a master restart. In this case I also believe ...
6 years, 11 months ago (2014-01-13 18:41:34 UTC) #3
gab
6 years, 11 months ago (2014-01-15 20:04:04 UTC) #4
On 2014/01/13 18:41:34, Paweł Hajdan Jr. wrote:
> Hey Gabriel, yes this would require a master restart. In this case I also
> believe it's not the right way to fix it. "not lgtm"
> 
> Good news is that the right way would not need a master restart. Please see
> chrome/test/base/browser_tests_main.cc - if that's the main for your test
> binary, just force the number of jobs to one on --ash-browsertests (make sure
to
> print something about that and flush stdout). Send the review my way.
> 
> Let me know if I can help more. The idea is that the information it needs to
run
> serially should be within the test binary itself, rather than duplicated in
> every caller.

sg, sent you https://codereview.chromium.org/132313006/ for this. Closing this
one now.

Cheers,
Gab

Powered by Google App Engine
This is Rietveld 408576698