Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: tools/roll_deps.py

Issue 134723002: Fixes to roll_deps for the bots (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/roll_deps.py
diff --git a/tools/roll_deps.py b/tools/roll_deps.py
index 2f98fb548cb7a3254d90b223f8ec42d9b44bc207..10822f4d4c754ecb922799df420baa120ca11242 100755
--- a/tools/roll_deps.py
+++ b/tools/roll_deps.py
@@ -577,8 +577,8 @@ class GitBranchCLUpload(object):
if self._stash:
vsp.check_call([git, 'stash', 'save'])
try:
- self._original_branch = vsp.strip_output(
- [git, 'symbolic-ref', '--short', 'HEAD'])
+ full_branch = vsp.strip_output([git, 'symbolic-ref', 'HEAD'])
+ self._original_branch = full_branch.split('/')[-1]
except (subprocess.CalledProcessError,):
self._original_branch = vsp.strip_output(
[git, 'rev-parse', 'HEAD'])
@@ -588,7 +588,7 @@ class GitBranchCLUpload(object):
if branch_exists(self._branch_name):
vsp.check_call([git, 'checkout', '-q', 'master'])
- vsp.check_call([git, 'branch', '-q', '-D', self._branch_name])
+ vsp.check_call([git, 'branch', '-D', self._branch_name])
vsp.check_call(
[git, 'checkout', '-q', '-b', self._branch_name, 'origin/master'])
@@ -632,7 +632,7 @@ class GitBranchCLUpload(object):
vsp.check_call([git, 'checkout', '-q', self._original_branch])
if self._config.default_branch_name == self._branch_name:
- vsp.check_call([git, 'branch', '-q', '-D', self._branch_name])
+ vsp.check_call([git, 'branch', '-D', self._branch_name])
if self._stash:
vsp.check_call([git, 'stash', 'pop'])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698