Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 1347213003: PPC: [runtime] Initial step towards switching Execution::Call to callable. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [runtime] Initial step towards switching Execution::Call to callable. Port d5bbd45f044ae6796c0d0f7bd8732069d74418de Original commit message: Currently Execution::Call (and friends) still duplicate a lot of the Call sequence logic that should be encapsulated in the Call and CallFunction builtins. So the plan now is to switch Execution::Call to accept any Callable and just pass that through to the Call builtin. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=v8:4413 LOG=n Committed: https://crrev.com/05c804fc1af8655595fe98deedd6bbc3a96f2973 Cr-Commit-Position: refs/heads/master@{#30813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/ppc/builtins-ppc.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
MTBrandyberry
5 years, 3 months ago (2015-09-17 19:45:24 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347213003/1
5 years, 3 months ago (2015-09-17 20:09:59 UTC) #3
michael_dawson
On 2015/09/17 20:09:59, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 3 months ago (2015-09-17 20:16:25 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-17 20:35:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347213003/1
5 years, 3 months ago (2015-09-17 20:38:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 20:39:55 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 20:40:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05c804fc1af8655595fe98deedd6bbc3a96f2973
Cr-Commit-Position: refs/heads/master@{#30813}

Powered by Google App Engine
This is Rietveld 408576698