Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1347213002: Make WebKit Mac10.9 (retina) bot not use the 10.6 SDK. (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
Reviewers:
erikchen, Adrian Kuegel
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
build
Visibility:
Public.

Description

Make WebKit Mac10.9 (retina) bot not use the 10.6 SDK. Most WebKit tester bots only run tests. The retina bot however builds and runs tests (see http://crbug.com/464459). The tester bots don't all have the 10.10 SDK installed yet which is why they currently use the 10.6 SDK (http://crbug.com/515310). Since the retina bot also builds and we no longer support building with the 10.6 SDK, it got its SDK updated earlier (http://crbug.com/532504). This change makes it so that the bot uses that updated SDK. BUG=464459, 515310, 532504 TBR=akuegel Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296714

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_9__retina_.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Nico
since it's causing work and pain: how's progress on crbug.com/515310 going? :-)
5 years, 3 months ago (2015-09-16 19:37:11 UTC) #2
erikchen
On 2015/09/16 19:37:11, Nico wrote: > since it's causing work and pain: how's progress on ...
5 years, 3 months ago (2015-09-16 19:49:25 UTC) #3
erikchen
lgtm
5 years, 3 months ago (2015-09-16 19:50:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347213002/1
5 years, 3 months ago (2015-09-16 19:51:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: build_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit/builds/1727)
5 years, 3 months ago (2015-09-16 19:55:09 UTC) #8
Nico
tbr akuegel due to that noparent thing
5 years, 3 months ago (2015-09-16 19:56:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347213002/1
5 years, 3 months ago (2015-09-16 19:56:17 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=296714
5 years, 3 months ago (2015-09-16 19:58:22 UTC) #13
Adrian Kuegel
5 years, 3 months ago (2015-09-17 08:11:15 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698