Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2461)

Unified Diff: device/bluetooth/dbus/bluetooth_agent_service_provider.cc

Issue 1347193004: Refactor DBusThreadManager to split away BT clients. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/dbus/bluetooth_agent_service_provider.cc
diff --git a/chromeos/dbus/bluetooth_agent_service_provider.cc b/device/bluetooth/dbus/bluetooth_agent_service_provider.cc
similarity index 90%
rename from chromeos/dbus/bluetooth_agent_service_provider.cc
rename to device/bluetooth/dbus/bluetooth_agent_service_provider.cc
index 97eb273c42e57b1b8083f3b4826d9d76835a3ae6..7392f2b0c52b7458a6497a2e219f9d3749b970cc 100644
--- a/chromeos/dbus/bluetooth_agent_service_provider.cc
+++ b/device/bluetooth/dbus/bluetooth_agent_service_provider.cc
@@ -2,24 +2,22 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chromeos/dbus/bluetooth_agent_service_provider.h"
-
+#include "device/bluetooth/dbus/bluetooth_agent_service_provider.h"
#include "base/bind.h"
#include "base/logging.h"
#include "base/memory/ref_counted.h"
#include "base/threading/platform_thread.h"
-#include "chromeos/dbus/dbus_thread_manager.h"
-#include "chromeos/dbus/fake_bluetooth_agent_service_provider.h"
#include "dbus/exported_object.h"
#include "dbus/message.h"
+#include "device/bluetooth/dbus/bluez_dbus_manager.h"
+#include "device/bluetooth/dbus/fake_bluetooth_agent_service_provider.h"
#include "third_party/cros_system_api/dbus/service_constants.h"
-namespace chromeos {
+namespace bluez {
// The BluetoothAgentServiceProvider implementation used in production.
-class BluetoothAgentServiceProviderImpl
- : public BluetoothAgentServiceProvider {
+class BluetoothAgentServiceProviderImpl : public BluetoothAgentServiceProvider {
public:
BluetoothAgentServiceProviderImpl(dbus::Bus* bus,
const dbus::ObjectPath& object_path,
@@ -34,8 +32,7 @@ class BluetoothAgentServiceProviderImpl
exported_object_ = bus_->GetExportedObject(object_path_);
exported_object_->ExportMethod(
- bluetooth_agent::kBluetoothAgentInterface,
- bluetooth_agent::kRelease,
+ bluetooth_agent::kBluetoothAgentInterface, bluetooth_agent::kRelease,
base::Bind(&BluetoothAgentServiceProviderImpl::Release,
weak_ptr_factory_.GetWeakPtr()),
base::Bind(&BluetoothAgentServiceProviderImpl::OnExported,
@@ -98,8 +95,7 @@ class BluetoothAgentServiceProviderImpl
weak_ptr_factory_.GetWeakPtr()));
exported_object_->ExportMethod(
- bluetooth_agent::kBluetoothAgentInterface,
- bluetooth_agent::kCancel,
+ bluetooth_agent::kBluetoothAgentInterface, bluetooth_agent::kCancel,
base::Bind(&BluetoothAgentServiceProviderImpl::Cancel,
weak_ptr_factory_.GetWeakPtr()),
base::Bind(&BluetoothAgentServiceProviderImpl::OnExported,
@@ -148,9 +144,7 @@ class BluetoothAgentServiceProviderImpl
Delegate::PinCodeCallback callback = base::Bind(
&BluetoothAgentServiceProviderImpl::OnPinCode,
- weak_ptr_factory_.GetWeakPtr(),
- method_call,
- response_sender);
+ weak_ptr_factory_.GetWeakPtr(), method_call, response_sender);
delegate_->RequestPinCode(device_path, callback);
}
@@ -166,8 +160,7 @@ class BluetoothAgentServiceProviderImpl
dbus::MessageReader reader(method_call);
dbus::ObjectPath device_path;
std::string pincode;
- if (!reader.PopObjectPath(&device_path) ||
- !reader.PopString(&pincode)) {
+ if (!reader.PopObjectPath(&device_path) || !reader.PopString(&pincode)) {
LOG(WARNING) << "DisplayPinCode called with incorrect paramters: "
<< method_call->ToString();
return;
@@ -195,9 +188,7 @@ class BluetoothAgentServiceProviderImpl
Delegate::PasskeyCallback callback = base::Bind(
&BluetoothAgentServiceProviderImpl::OnPasskey,
- weak_ptr_factory_.GetWeakPtr(),
- method_call,
- response_sender);
+ weak_ptr_factory_.GetWeakPtr(), method_call, response_sender);
delegate_->RequestPasskey(device_path, callback);
}
@@ -214,8 +205,7 @@ class BluetoothAgentServiceProviderImpl
dbus::ObjectPath device_path;
uint32 passkey;
uint16 entered;
- if (!reader.PopObjectPath(&device_path) ||
- !reader.PopUint32(&passkey) ||
+ if (!reader.PopObjectPath(&device_path) || !reader.PopUint32(&passkey) ||
!reader.PopUint16(&entered)) {
LOG(WARNING) << "DisplayPasskey called with incorrect paramters: "
<< method_call->ToString();
@@ -239,8 +229,7 @@ class BluetoothAgentServiceProviderImpl
dbus::MessageReader reader(method_call);
dbus::ObjectPath device_path;
uint32 passkey;
- if (!reader.PopObjectPath(&device_path) ||
- !reader.PopUint32(&passkey)) {
+ if (!reader.PopObjectPath(&device_path) || !reader.PopUint32(&passkey)) {
LOG(WARNING) << "RequestConfirmation called with incorrect paramters: "
<< method_call->ToString();
return;
@@ -248,9 +237,7 @@ class BluetoothAgentServiceProviderImpl
Delegate::ConfirmationCallback callback = base::Bind(
&BluetoothAgentServiceProviderImpl::OnConfirmation,
- weak_ptr_factory_.GetWeakPtr(),
- method_call,
- response_sender);
+ weak_ptr_factory_.GetWeakPtr(), method_call, response_sender);
delegate_->RequestConfirmation(device_path, passkey, callback);
}
@@ -258,8 +245,8 @@ class BluetoothAgentServiceProviderImpl
// Called by dbus:: when the Bluetooth daemon requires that the user
// confirm an incoming just-works pairing.
void RequestAuthorization(
- dbus::MethodCall* method_call,
- dbus::ExportedObject::ResponseSender response_sender) {
+ dbus::MethodCall* method_call,
+ dbus::ExportedObject::ResponseSender response_sender) {
DCHECK(OnOriginThread());
DCHECK(delegate_);
@@ -273,9 +260,7 @@ class BluetoothAgentServiceProviderImpl
Delegate::ConfirmationCallback callback = base::Bind(
&BluetoothAgentServiceProviderImpl::OnConfirmation,
- weak_ptr_factory_.GetWeakPtr(),
- method_call,
- response_sender);
+ weak_ptr_factory_.GetWeakPtr(), method_call, response_sender);
delegate_->RequestAuthorization(device_path, callback);
}
@@ -291,8 +276,7 @@ class BluetoothAgentServiceProviderImpl
dbus::MessageReader reader(method_call);
dbus::ObjectPath device_path;
std::string uuid;
- if (!reader.PopObjectPath(&device_path) ||
- !reader.PopString(&uuid)) {
+ if (!reader.PopObjectPath(&device_path) || !reader.PopString(&uuid)) {
LOG(WARNING) << "AuthorizeService called with incorrect paramters: "
<< method_call->ToString();
return;
@@ -300,9 +284,7 @@ class BluetoothAgentServiceProviderImpl
Delegate::ConfirmationCallback callback = base::Bind(
&BluetoothAgentServiceProviderImpl::OnConfirmation,
- weak_ptr_factory_.GetWeakPtr(),
- method_call,
- response_sender);
+ weak_ptr_factory_.GetWeakPtr(), method_call, response_sender);
delegate_->AuthorizeService(device_path, uuid, callback);
}
@@ -323,8 +305,8 @@ class BluetoothAgentServiceProviderImpl
void OnExported(const std::string& interface_name,
const std::string& method_name,
bool success) {
- LOG_IF(WARNING, !success) << "Failed to export "
- << interface_name << "." << method_name;
+ LOG_IF(WARNING, !success) << "Failed to export " << interface_name << "."
+ << method_name;
}
// Called by the Delegate to response to a method requesting a PIN code.
@@ -443,22 +425,20 @@ class BluetoothAgentServiceProviderImpl
DISALLOW_COPY_AND_ASSIGN(BluetoothAgentServiceProviderImpl);
};
-BluetoothAgentServiceProvider::BluetoothAgentServiceProvider() {
-}
+BluetoothAgentServiceProvider::BluetoothAgentServiceProvider() {}
-BluetoothAgentServiceProvider::~BluetoothAgentServiceProvider() {
-}
+BluetoothAgentServiceProvider::~BluetoothAgentServiceProvider() {}
// static
BluetoothAgentServiceProvider* BluetoothAgentServiceProvider::Create(
dbus::Bus* bus,
const dbus::ObjectPath& object_path,
Delegate* delegate) {
- if (!DBusThreadManager::Get()->IsUsingStub(DBusClientBundle::BLUETOOTH)) {
+ if (!bluez::BluezDBusManager::Get()->IsUsingStub()) {
return new BluetoothAgentServiceProviderImpl(bus, object_path, delegate);
} else {
return new FakeBluetoothAgentServiceProvider(object_path, delegate);
}
}
-} // namespace chromeos
+} // namespace bluez
« no previous file with comments | « device/bluetooth/dbus/bluetooth_agent_service_provider.h ('k') | device/bluetooth/dbus/bluetooth_dbus_client_bundle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698