Add cr-settings-radio-group wrapper

Add cr-settings-radio-group wrapper

We need a cr-settings wrapper for policy indicators regardless.
I think it makes snese to do any pref / selected conversion here also.

BUG=521791
Committed: https://crrev.com/13950c54d23465391429358f272bc69e874ab8db
Cr-Commit-Position: refs/heads/master@{#349476}

[stevenjb, 2015-09-16 19:41:14]

stevenjb@chromium.org changed reviewers:
+ dbeam@chromium.org, dschuyler@chromium.org, michaelpg@chromium.org

[stevenjb, 2015-09-16 19:41:14]

LMKWYT

[Dan Beam, 2015-09-16 22:29:37]

https://codereview.chromium.org/1347193003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/appearance_page/appearance_page.html
(right):

https://codereview.chromium.org/1347193003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/appearance_page/appearance_page.html:30:
hidden="[[!prefs.browser.show_home_button.value]]"
lgtm assuming this (and possibly other things) get dom-if'd out when paper-*
elements are involved

https://codereview.chromium.org/1347193003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/radio_group/radio_group.js (right):

https://codereview.chromium.org/1347193003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/radio_group/radio_group.js:60:
console.error('Bad selected name for numerical pref: ' + this.selected);
why not just assert(!isNan(n))?

[stevenjb, 2015-09-17 00:42:01]

Updated to use dom-if, PTAL

dschuyler@ - WDYT? I don't want to stomp over your changes in
https://codereview.chromium.org/1345913002/, but we will want to switch to
settings-radio-group throughout to pick up the control indicator changes
regardless, and I do think that this is a bit cleaner than requiring an extra
parameter in any page that needs to map a boolean to a radio (even if it ends up
being just the one).

https://codereview.chromium.org/1347193003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/appearance_page/appearance_page.html
(right):

https://codereview.chromium.org/1347193003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/appearance_page/appearance_page.html:30:
hidden="[[!prefs.browser.show_home_button.value]]"
On 2015/09/16 22:29:37, Dan Beam wrote:
> lgtm assuming this (and possibly other things) get dom-if'd out when paper-*
> elements are involved

I started a doc to discuss this sort of thing, but after reading more about
dom-if it seems clear that dom-if is a win, thanks for pointing that out.

[stevenjb, 2015-09-17 00:42:24]

On 2015/09/17 00:42:01, stevenjb wrote:
> Updated to use dom-if, PTAL
> 
> dschuyler@ - WDYT? I don't want to stomp over your changes in
> https://codereview.chromium.org/1345913002/, but we will want to switch to
> settings-radio-group throughout to pick up the control indicator changes
> regardless, and I do think that this is a bit cleaner than requiring an extra
> parameter in any page that needs to map a boolean to a radio (even if it ends
up
> being just the one).
> 
>
https://codereview.chromium.org/1347193003/diff/1/chrome/browser/resources/se...
> File chrome/browser/resources/settings/appearance_page/appearance_page.html
> (right):
> 
>
https://codereview.chromium.org/1347193003/diff/1/chrome/browser/resources/se...
> chrome/browser/resources/settings/appearance_page/appearance_page.html:30:
> hidden="[[!prefs.browser.show_home_button.value]]"
> On 2015/09/16 22:29:37, Dan Beam wrote:
> > lgtm assuming this (and possibly other things) get dom-if'd out when paper-*
> > elements are involved
> 
> I started a doc to discuss this sort of thing, but after reading more about
> dom-if it seems clear that dom-if is a win, thanks for pointing that out.

Link to doc:
https://docs.google.com/document/d/1G0t519y_cSW4etXVwruR145abZH0N5-9R7JyejzVo...

[dschuyler, 2015-09-17 18:59:44]

https://codereview.chromium.org/1347193003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/on_startup_page/on_startup_page.html
(right):

https://codereview.chromium.org/1347193003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/on_startup_page/on_startup_page.html:31:
</paper-button>
Hi, When I've tried putting a button or input inside of a radio button, the
events stop reaching the inner element.  I'm curious if you've not seen this or
have a solution that I missed in this CL :)

[dschuyler, 2015-09-17 19:00:46]

On 2015/09/17 18:59:44, dschuyler wrote:
>
https://codereview.chromium.org/1347193003/diff/20001/chrome/browser/resource...
> File chrome/browser/resources/settings/on_startup_page/on_startup_page.html
> (right):
> 
>
https://codereview.chromium.org/1347193003/diff/20001/chrome/browser/resource...
> chrome/browser/resources/settings/on_startup_page/on_startup_page.html:31:
> </paper-button>
> Hi, When I've tried putting a button or input inside of a radio button, the
> events stop reaching the inner element.  I'm curious if you've not seen this
or
> have a solution that I missed in this CL :)

LGTM other than my question above (which may be a non-issue if you've addressed
it).

[stevenjb, 2015-09-17 19:29:06]

https://codereview.chromium.org/1347193003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/on_startup_page/on_startup_page.html
(right):

https://codereview.chromium.org/1347193003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/on_startup_page/on_startup_page.html:31:
</paper-button>
On 2015/09/17 18:59:43, dschuyler wrote:
> Hi, When I've tried putting a button or input inside of a radio button, the
> events stop reaching the inner element.  I'm curious if you've not seen this
or
> have a solution that I missed in this CL :)

Huh, you are entirely correct, I clearly didn't test that. I've reverted that
change since it is unrelated to the rest of this CL.

[stevenjb, 2015-09-17 19:29:10]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2015-09-17 19:29:10]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org,
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/1347193003/#ps40001
(title: "Revert startup pages button change")

[commit-bot: I haz the power, 2015-09-17 19:29:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1347193003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1347193003/40001

[commit-bot: I haz the power, 2015-09-17 20:10:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-17 20:10:44]

Patchset 3 (id:??) landed as
https://crrev.com/13950c54d23465391429358f272bc69e874ab8db
Cr-Commit-Position: refs/heads/master@{#349476}