Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Side by Side Diff: docs/contributing.md

Issue 1347153006: [Docs] Add wiki content to Markdown docs (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 Here you will find information that you'll need to be able to contribute to V8. Be sure to read the whole thing before sending us a contribution, including the small print at the end.
2
3 ## Before you contribute
4
5 Before you start working on a larger contribution V8 you should get in touch wit h us first through the V8 [contributor mailing list](http://groups.google.com/gr oup/v8-dev) so we can help out and possibly guide you; coordinating up front mak es it much easier to avoid frustration later on.
6
7 ## Getting the code
8
9 See [UsingGit](using_git.md).
10
11 ## Submitting code
12
13 The source code of V8 follows the [Google C++ Style Guide](http://google-stylegu ide.googlecode.com/svn/trunk/cppguide.xml) so you should familiarize yourself wi th those guidelines. Before submitting code you must pass all our [tests](http: //code.google.com/p/v8-wiki/wiki/Testing), and have to successfully run the pres ubmit checks:
14
15 > `tools/presubmit.py`
16
17 The presubmit script uses a linter from Google, `cpplint.py`. External contribu tors can get this from [here](http://google-styleguide.googlecode.com/svn/trunk/ cpplint/cpplint.py) and place it in their path.
18
19 All submissions, including submissions by project members, require review. We u se the same code-review tools and process as the chromium project. In order to submit a patch, you need to get the [depot\_tools](http://dev.chromium.org/devel opers/how-tos/install-depot-tools) and follow these instructions on [requesting a review](http://dev.chromium.org/developers/contributing-code) (using your V8 w orkspace instead of a chromium workspace).
20
21 ### Look out for breakage or regressions
22
23 Before submitting your code please check the [buildbot console](http://build.chr omium.org/p/client.v8/console) to see that the columns are mostly green before c hecking in your changes. Otherwise you will not know if your changes break the b uild or not. When your change is committed watch the [buildbot console](http://b uild.chromium.org/p/client.v8/console) until the bots turn green after your chan ge.
24
25
26 ## The small print
27
28 Before we can use your code you have to sign the [Google Individual Contributor License Agreement](http://code.google.com/legal/individual-cla-v1.0.html), which you can do online. This is mainly because you own the copyright to your change s, even after your contribution becomes part of our codebase, so we need your pe rmission to use and distribute your code. We also need to be sure of various ot her things, for instance that you'll tell us if you know that your code infringe s on other people's patents. You don't have to do this until after you've submi tted your code for review and a member has approved it, but you will have to do it before we can put your code into our codebase.
29
30 Contributions made by corporations are covered by a different agreement than the one above, the [Software Grant and Corporate Contributor License Agreement](htt p://code.google.com/legal/corporate-cla-v1.0.html).
31
32 Sign them online [here](https://cla.developers.google.com/)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698