Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 1347113004: Tracing flow events v2 in Blink (Closed)

Created:
5 years, 3 months ago by oystein (OOO til 10th of July)
Modified:
5 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Support tracing flow events v2 in Blink This includes passing an additional bindId parameter to Chrome, and increasing the size of the flags field from char to int (it's been an int in Chrome for some time). Prerequisite (Chrome side CL) is https://codereview.chromium.org/1354453002/ R=tkent BUG=532726

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -41 lines) Patch
M Source/platform/EventTracer.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M Source/platform/EventTracer.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
M Source/platform/TraceEvent.h View 12 chunks +57 lines, -32 lines 0 comments Download
M public/platform/Platform.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 22 (10 generated)
oystein (OOO til 10th of July)
ptal :)
5 years, 3 months ago (2015-09-18 00:01:51 UTC) #3
oystein (OOO til 10th of July)
ptal :)
5 years, 3 months ago (2015-09-18 00:02:23 UTC) #5
tkent
https://codereview.chromium.org/1347113004/diff/40001/public/platform/Platform.h File public/platform/Platform.h (right): https://codereview.chromium.org/1347113004/diff/40001/public/platform/Platform.h#newcode549 public/platform/Platform.h:549: unsigned long long bindId, When this CL is landed, ...
5 years, 3 months ago (2015-09-18 00:43:49 UTC) #6
oystein (OOO til 10th of July)
https://codereview.chromium.org/1347113004/diff/40001/public/platform/Platform.h File public/platform/Platform.h (right): https://codereview.chromium.org/1347113004/diff/40001/public/platform/Platform.h#newcode549 public/platform/Platform.h:549: unsigned long long bindId, On 2015/09/18 00:43:48, tkent wrote: ...
5 years, 3 months ago (2015-09-18 01:42:15 UTC) #7
tkent
https://codereview.chromium.org/1347113004/diff/40001/public/platform/Platform.h File public/platform/Platform.h (right): https://codereview.chromium.org/1347113004/diff/40001/public/platform/Platform.h#newcode549 public/platform/Platform.h:549: unsigned long long bindId, On 2015/09/18 at 01:42:15, Oystein ...
5 years, 3 months ago (2015-09-18 02:20:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347113004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347113004/40001
5 years, 3 months ago (2015-09-21 19:07:41 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/116276)
5 years, 3 months ago (2015-09-21 20:20:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347113004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347113004/40001
5 years, 3 months ago (2015-09-22 00:08:28 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/116480)
5 years, 3 months ago (2015-09-22 01:14:09 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347113004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347113004/60001
5 years, 3 months ago (2015-09-23 20:49:46 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/101473)
5 years, 3 months ago (2015-09-23 20:50:47 UTC) #21
oystein (OOO til 10th of July)
5 years, 2 months ago (2015-10-07 00:33:59 UTC) #22
Message was sent while issue was closed.
Landed in https://codereview.chromium.org/1359973003/ instead due to Blink repo
merge.

Powered by Google App Engine
This is Rietveld 408576698