Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: dart/utils/apidoc/apidoc.dart

Issue 13471015: Ensure apidoc exits with non-zero exit code when dart2js crashes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/sdk/lib/_internal/dartdoc/bin/dartdoc.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/utils/apidoc/apidoc.dart
diff --git a/dart/utils/apidoc/apidoc.dart b/dart/utils/apidoc/apidoc.dart
index 5405e3a7233c26f995614c55be3e409a7bb3a8cf..6d7d70d5e2f4c0e7085389b1d8317a2ef39bf8a5 100644
--- a/dart/utils/apidoc/apidoc.dart
+++ b/dart/utils/apidoc/apidoc.dart
@@ -150,7 +150,10 @@ void main() {
.then((_) => apidoc.documentLibraries(apidocLibraries, libPath, pkgPath))
.then((_) => compileScript(mode, outputDir, libPath))
.then((_) => print(apidoc.status))
- .catchError((e) => print('Error: generation failed: ${e.error}'))
+ .catchError((e) {
+ print('Error: generation failed: ${e}');
kevmoo-old 2013/04/03 02:08:49 Does apidoc.cleanup() get called in the error case
ahe 2013/04/04 10:26:01 Good point, thank you! Done.
+ exit(1);
+ })
.whenComplete(() => apidoc.cleanup());
});
}
« no previous file with comments | « dart/sdk/lib/_internal/dartdoc/bin/dartdoc.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698