Issue 13471011: Fix build error when building Android in Release mode with -O2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13471011: Fix build error when building Android in Release mode with -O2. (Closed)

Created:
7 years, 8 months ago by djsollen

Modified:
7 years, 8 months ago

Reviewers:
edisonn, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix build error when building Android in Release mode with -O2. This fixes the folowing error... ../../../src/pdf/SkPDFShader.cpp: In function 'void gradientFunctionCode(const SkShader::GradientInfo&, SkString*)': ../../../src/pdf/SkPDFShader.cpp:69:19: error: array subscript is above array bounds [-Werror=array-bounds] Committed: https://code.google.com/p/skia/source/detail?r=8506

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -13 lines)			Patch
	M	src/pdf/SkPDFShader.cpp	View		3 chunks	+12 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

7 years, 8 months ago (2013-04-03 12:30:45 UTC) #3

djsollen

7 years, 8 months ago (2013-04-03 12:34:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r8506 (presubmit successful).

Expand Messages | Collapse Messages