Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 1347093003: Rewrite the JDIMENSION argument management for x86 64-bit assembly to (Closed)

Created:
5 years, 3 months ago by hans
Modified:
5 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rewrite the JDIMENSION argument management for x86 64-bit assembly to correctly handle a 32-bit argument width. The ABI leaves the high 32 bits undefined when passing 32-bit integers through arguments. Also enhance the documentation of JDIMENSION to explain that its size is significant to the implementation of the assembly. This prevents libjpeg_turbo from crashing when compiled with recent versions of Clang. This patch has been sent upstream: https://github.com/libjpeg-turbo/libjpeg-turbo/pull/20 BUG=532214 R=thakis@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo/+/52e8b6949a23a95fe1b6118805579e9aea268c3e

Patch Set 1 #

Patch Set 2 : README.chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -27 lines) Patch
M README.chromium View 1 1 chunk +2 lines, -0 lines 0 comments Download
M jmorecfg.h View 1 chunk +3 lines, -1 line 0 comments Download
M simd/jcclrss2-64.asm View 1 chunk +2 lines, -2 lines 0 comments Download
M simd/jcgryss2-64.asm View 1 chunk +2 lines, -2 lines 0 comments Download
M simd/jcqnts2f-64.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jcqnts2i-64.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jcsamss2-64.asm View 4 chunks +5 lines, -5 lines 0 comments Download
M simd/jdclrss2-64.asm View 1 chunk +2 lines, -2 lines 0 comments Download
M simd/jdmrgss2-64.asm View 2 chunks +4 lines, -4 lines 0 comments Download
M simd/jdsamss2-64.asm View 3 chunks +4 lines, -4 lines 0 comments Download
M simd/jiss2flt-64.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jiss2fst-64.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jiss2int-64.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jiss2red-64.asm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hans
Please take a look. I also learned that some of these files (e.g. jdclrss2-64.asm) are ...
5 years, 3 months ago (2015-09-16 16:54:26 UTC) #2
Nico
lgtm
5 years, 3 months ago (2015-09-16 17:20:21 UTC) #3
hans
5 years, 3 months ago (2015-09-16 17:24:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
52e8b6949a23a95fe1b6118805579e9aea268c3e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698