Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1347063004: [ic] Introduce BOOLEAN state for CompareIC. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Introduce BOOLEAN state for CompareIC. Slow path for relational comparison of boolean primitive values now goes through the runtime, which made the slow path even slower than it already was. So in order to repair the regression, we just track boolean feedback for comparisons and use that to generate decent code in Crankshaft (not the best possible code, but good enough for Crankshaft; TurboFan will be able to do better on that). R=jarin@chromium.org BUG=chromium:534200 LOG=n Committed: https://crrev.com/10c5f2e85ef92b7ca002ef95e406d5dc4f0c410b Cr-Commit-Position: refs/heads/master@{#30860}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -0 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M src/code-stubs.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M src/ic/ic-state.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ic/ic-state.cc View 7 chunks +11 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347063004/1
5 years, 3 months ago (2015-09-21 18:40:38 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_rel/builds/4838)
5 years, 3 months ago (2015-09-21 18:43:51 UTC) #4
Benedikt Meurer
Hey Jaro, This is the second part of the Box2d fixification after moving those semi ...
5 years, 3 months ago (2015-09-22 07:36:44 UTC) #10
Jarin
lgtm. Yes, more Crankshaft awesomeness!
5 years, 3 months ago (2015-09-22 07:44:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347063004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347063004/80001
5 years, 3 months ago (2015-09-22 07:54:17 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:80001)
5 years, 3 months ago (2015-09-22 08:01:31 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 08:01:50 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10c5f2e85ef92b7ca002ef95e406d5dc4f0c410b
Cr-Commit-Position: refs/heads/master@{#30860}

Powered by Google App Engine
This is Rietveld 408576698