Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1347063003: Remove deprecation warning for fullscreen on insecure origins (Closed)

Created:
5 years, 3 months ago by jww
Modified:
5 years, 3 months ago
Reviewers:
chrishtr, philipj_slow
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, palmer, philipj_slow, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove deprecation warning for fullscreen on insecure origins Although we still plan to eventually deprecate fullscreen on insecure origins, the usage numbers are high enough now that the warning is essentially console spam. This CL removes the deprecation warning until we can lower usage significantly. BUG=534455 R=chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202590

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -23 lines) Patch
M LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html View 1 chunk +0 lines, -17 lines 0 comments Download
M LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/dom/Fullscreen.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
jww
chrishtr@, can you take a look at this removal of the fullscreen deprecation warning?
5 years, 3 months ago (2015-09-19 16:27:57 UTC) #1
jww
5 years, 3 months ago (2015-09-19 16:28:14 UTC) #3
philipj_slow
lgtm
5 years, 3 months ago (2015-09-21 09:13:44 UTC) #5
chrishtr
lgtm
5 years, 3 months ago (2015-09-21 15:58:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347063003/1
5 years, 3 months ago (2015-09-21 15:59:01 UTC) #8
jww
On 2015/09/21 15:59:01, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 3 months ago (2015-09-21 17:31:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347063003/1
5 years, 3 months ago (2015-09-21 17:33:27 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 18:04:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202590

Powered by Google App Engine
This is Rietveld 408576698