Issue 1347063002: Teach `benchmark.mojo` to save the collected trace file to disk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1347063002: Teach `benchmark.mojo` to save the collected trace file to disk. (Closed)

Created:
5 years, 3 months ago by ppi

Modified:
5 years, 3 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Teach `benchmark.mojo` to save the collected trace file to disk. This patch adds `--save-traces` argument to mojo_benchmark which saves the traces collected in each benchmark run to disk. A follow-up patch will need teach the runner to move these files to a better location on the host machine (including from an Android device). Fixes #417. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ddfda66c8b3b27457acf97fcfb4ff960440f9a35

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -6 lines)			Patch
M	apps/benchmark/README.md	View		2 chunks	+8 lines, -3 lines	0 comments	Download
M	apps/benchmark/benchmark_app.cc	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download
M	apps/benchmark/run_args.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	apps/benchmark/run_args.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	mojo/devtools/common/mojo_benchmark	View		5 chunks	+15 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ppi

5 years, 3 months ago (2015-09-16 13:56:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ddfda66c8b3b27457acf97fcfb4ff960440f9a35.

Expand Messages | Collapse Messages