chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java - Issue 1347023004: [Contextual Search] Add close button in maximized state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java

Issue 1347023004: [Contextual Search] Add close button in maximized state (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelFeatures.java ('k') | chrome/browser/android/compositor/layer/contextual_search_layer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java

index ed13d4662d0f890495e923b708de50125da39268..1b216d3daca916ed7df8cfa9bf57a2051664e528 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java

@@ -60,7 +60,6 @@ public class ContextualSearchSceneLayer extends SceneLayer {

float arrowIconOpacity = mSearchPanel.getArrowIconOpacity();

float arrowIconRotation = mSearchPanel.getArrowIconRotation();

- boolean closeIconVisible = mSearchPanel.isCloseIconVisible();

float closeIconOpacity = mSearchPanel.getCloseIconOpacity();

boolean isProgressBarVisible = mSearchPanel.isProgressBarVisible();

@@ -99,7 +98,6 @@ public class ContextualSearchSceneLayer extends SceneLayer {

searchBarShadowOpacity,

arrowIconOpacity,

arrowIconRotation,

- closeIconVisible,

closeIconOpacity,

isProgressBarVisible,

progressBarY * mDpToPx,

@@ -158,7 +156,6 @@ public class ContextualSearchSceneLayer extends SceneLayer {

float searchBarShadowOpacity,

float arrowIconOpacity,

float arrowIconRotation,

- boolean closeIconVisible,

float closeIconOpacity,

boolean isProgressBarVisible,

float progressBarY,