Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1347023003: Rename frame classes (Closed)

Created:
5 years, 3 months ago by sky
Modified:
5 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename frame classes The mojom is now in web_view.mojom. FrameTreeServer->Frame FrameTreeClient->FrameClient BUG=none TEST=none R=ben@chromium.org TBR=ben@chromium.org Committed: https://crrev.com/9f4305978e360ae86d3f7e1b91cf7793a59848d1 Cr-Commit-Position: refs/heads/master@{#350032}

Patch Set 1 #

Patch Set 2 : merge 2 trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+400 lines, -564 lines) Patch
M components/html_viewer/ax_provider_apptest.cc View 3 chunks +23 lines, -23 lines 0 comments Download
M components/html_viewer/document_resource_waiter.h View 5 chunks +21 lines, -22 lines 0 comments Download
M components/html_viewer/document_resource_waiter.cc View 7 chunks +22 lines, -21 lines 0 comments Download
M components/html_viewer/html_document.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/html_viewer/html_document.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/html_viewer/html_frame.h View 8 chunks +19 lines, -20 lines 0 comments Download
M components/html_viewer/html_frame.cc View 8 chunks +28 lines, -26 lines 0 comments Download
M components/html_viewer/html_frame_apptest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/html_viewer/html_frame_tree_manager.h View 4 chunks +9 lines, -9 lines 0 comments Download
M components/html_viewer/html_frame_tree_manager.cc View 10 chunks +21 lines, -20 lines 0 comments Download
M components/web_view/client_initiated_frame_connection.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M components/web_view/client_initiated_frame_connection.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/web_view/frame.h View 9 chunks +38 lines, -36 lines 0 comments Download
M components/web_view/frame.cc View 15 chunks +61 lines, -66 lines 0 comments Download
M components/web_view/frame_apptest.cc View 1 17 chunks +68 lines, -74 lines 0 comments Download
M components/web_view/frame_connection.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/web_view/frame_connection.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/web_view/frame_tree.h View 3 chunks +13 lines, -12 lines 0 comments Download
M components/web_view/frame_tree.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M components/web_view/frame_tree_delegate.h View 1 chunk +9 lines, -6 lines 0 comments Download
M components/web_view/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + components/web_view/public/interfaces/frame.mojom View 1 5 chunks +20 lines, -20 lines 0 comments Download
D components/web_view/public/interfaces/frame_tree.mojom View 1 chunk +0 lines, -164 lines 0 comments Download
M components/web_view/test_frame_tree_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/web_view/test_frame_tree_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/web_view/web_view_impl.h View 2 chunks +6 lines, -3 lines 0 comments Download
M components/web_view/web_view_impl.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
5 years, 3 months ago (2015-09-21 21:11:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347023003/20001
5 years, 3 months ago (2015-09-21 21:14:56 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-21 21:48:22 UTC) #4
Ben Goodger (Google)
lgtm
5 years, 3 months ago (2015-09-21 21:48:38 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 21:49:39 UTC) #6
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9f4305978e360ae86d3f7e1b91cf7793a59848d1
Cr-Commit-Position: refs/heads/master@{#350032}

Powered by Google App Engine
This is Rietveld 408576698