Issue 13470009: Revert 191827 "Adds support for CoreAudioUtil::IsChannelLayoutSu..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13470009: Revert 191827 "Adds support for CoreAudioUtil::IsChannelLayoutSu..." (Closed)

Created:
7 years, 8 months ago by no longer working on chromium

Modified:
7 years, 8 months ago

Reviewers:
henrika (OOO until Aug 14)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 191827 "Adds support for CoreAudioUtil::IsChannelLayoutSu..." > Adds support for CoreAudioUtil::IsChannelLayoutSupported() > > BUG=177872 > TEST=media_unittests.exe --gtest_filter=Core* > > Review URL: https://chromiumcodereview.appspot.com/12918026 TBR=henrika@chromium.org It broke the XP browser_tests, see logs in http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%20Tests%20%282%29&number=26559 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191828

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -149 lines)			Patch
M	trunk/src/media/audio/win/audio_manager_win.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	trunk/src/media/audio/win/core_audio_util_win.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	trunk/src/media/audio/win/core_audio_util_win.cc	View	4 chunks	+15 lines, -106 lines	0 comments	Download
M	trunk/src/media/audio/win/core_audio_util_win_unittest.cc	View	1 chunk	+0 lines, -27 lines	0 comments	Download

Total messages: 2 (0 generated)

no longer working on chromium

7 years, 8 months ago (2013-04-02 14:19:43 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r191828.