Issue 13470008: Fix CopyBytes to accept size_t for num_bytes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13470008: Fix CopyBytes to accept size_t for num_bytes (Closed)

Created:
7 years, 8 months ago by Dmitry Lomov (no reviews)

Modified:
7 years, 8 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix CopyBytes to accept size_t for num_bytes BUG= Committed: https://code.google.com/p/v8/source/detail?r=14114

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -9 lines)			Patch
M	src/deoptimizer.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/heap.cc	View	2 chunks	+2 lines, -2 lines	1 comment	Download
M	src/objects.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/v8utils.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with one comments. https://codereview.chromium.org/13470008/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/13470008/diff/1/src/heap.cc#newcode3887 src/heap.cc:3887: CopyBytes(new_addr, old_addr, static_cast<size_t>(relocation_offset)); The "relocation_offset" ...

7 years, 8 months ago (2013-04-02 13:13:53 UTC) #2

Dmitry Lomov (no reviews)

7 years, 8 months ago (2013-04-02 13:29:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14114 (presubmit successful).

Expand Messages | Collapse Messages