Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: src/core/SkResourceCache.cpp

Issue 1346993006: Strip font name of special characters before dumping (Closed) Base URL: https://chromium.googlesource.com/skia.git@resource
Patch Set: Nit. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/core/SkGlyphCache.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkChecksum.h" 8 #include "SkChecksum.h"
9 #include "SkMessageBus.h" 9 #include "SkMessageBus.h"
10 #include "SkMipMap.h" 10 #include "SkMipMap.h"
(...skipping 661 matching lines...) Expand 10 before | Expand all | Expand 10 after
672 void SkResourceCache::TestDumpMemoryStatistics() { 672 void SkResourceCache::TestDumpMemoryStatistics() {
673 VisitAll(dump_visitor, nullptr); 673 VisitAll(dump_visitor, nullptr);
674 } 674 }
675 675
676 static void sk_trace_dump_visitor(const SkResourceCache::Rec& rec, void* context ) { 676 static void sk_trace_dump_visitor(const SkResourceCache::Rec& rec, void* context ) {
677 SkTraceMemoryDump* dump = static_cast<SkTraceMemoryDump*>(context); 677 SkTraceMemoryDump* dump = static_cast<SkTraceMemoryDump*>(context);
678 SkString dumpName = SkStringPrintf("skia/sk_resource_cache/%s_%p", rec.getCa tegory(), &rec); 678 SkString dumpName = SkStringPrintf("skia/sk_resource_cache/%s_%p", rec.getCa tegory(), &rec);
679 SkDiscardableMemory* discardable = rec.diagnostic_only_getDiscardable(); 679 SkDiscardableMemory* discardable = rec.diagnostic_only_getDiscardable();
680 if (discardable) { 680 if (discardable) {
681 dump->setDiscardableMemoryBacking(dumpName.c_str(), *discardable); 681 dump->setDiscardableMemoryBacking(dumpName.c_str(), *discardable);
682
683 // The discardable memory size will be calculated by dumper, but we also dump what we think
684 // the size of object in memory is irrespective of whether object is liv e or dead.
685 dump->dumpNumericValue(dumpName.c_str(), "discardable_size", "bytes", re c.bytesUsed());
682 } else { 686 } else {
683 dump->dumpNumericValue(dumpName.c_str(), "size", "bytes", rec.bytesUsed( )); 687 dump->dumpNumericValue(dumpName.c_str(), "size", "bytes", rec.bytesUsed( ));
684 dump->setMemoryBacking(dumpName.c_str(), "malloc", nullptr); 688 dump->setMemoryBacking(dumpName.c_str(), "malloc", nullptr);
685 } 689 }
686 } 690 }
687 691
688 void SkResourceCache::DumpMemoryStatistics(SkTraceMemoryDump* dump) { 692 void SkResourceCache::DumpMemoryStatistics(SkTraceMemoryDump* dump) {
689 // Since resource could be backed by malloc or discardable, the cache always dumps detailed 693 // Since resource could be backed by malloc or discardable, the cache always dumps detailed
690 // stats to be accurate. 694 // stats to be accurate.
691 VisitAll(sk_trace_dump_visitor, dump); 695 VisitAll(sk_trace_dump_visitor, dump);
692 } 696 }
OLDNEW
« no previous file with comments | « src/core/SkGlyphCache.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698