Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1346973002: Reland of "[heap] Concurrency support for heap book-keeping info" (Closed)

Created:
5 years, 3 months ago by Michael Lippautz
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of "[heap] Concurrency support for heap book-keeping info" Adds concurrency support for: - MemoryChunk: Fragmentation counters - MemoryChunk: High-water mark - MemoryAllocator: Lowest and highest ever allocated addresses, size, and capacity R=hpayer@chromium.org BUG=chromium:524425 LOG=N This reverts commit 0db34dbe8111f8670c82bb4c42110400a9050d08. BUG= Committed: https://crrev.com/6209753c74ee81f8310f4009bf30cade6b88b214 Cr-Commit-Position: refs/heads/master@{#30760}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -71 lines) Patch
M src/atomic-utils.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/heap/spaces.h View 9 chunks +68 lines, -52 lines 0 comments Download
M src/heap/spaces.cc View 8 chunks +21 lines, -19 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346973002/1
5 years, 3 months ago (2015-09-16 08:12:38 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 3 months ago (2015-09-16 08:13:10 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/8026)
5 years, 3 months ago (2015-09-16 08:14:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346973002/1
5 years, 3 months ago (2015-09-16 08:18:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/8027) v8_mac_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 3 months ago (2015-09-16 08:20:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346973002/1
5 years, 3 months ago (2015-09-16 08:26:19 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/7874) v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 3 months ago (2015-09-16 08:27:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346973002/1
5 years, 3 months ago (2015-09-16 10:41:04 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-16 11:18:13 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 11:18:38 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6209753c74ee81f8310f4009bf30cade6b88b214
Cr-Commit-Position: refs/heads/master@{#30760}

Powered by Google App Engine
This is Rietveld 408576698