Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1346963005: MIPS: [builtins] Add support for NewTarget to Execution::New. (Closed)

Created:
5 years, 3 months ago by akos.palfi.imgtec
Modified:
5 years, 1 month ago
Reviewers:
paul.l...
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [builtins] Add support for NewTarget to Execution::New. Port of https://codereview.chromium.org/1359583002/ Original commit message: Introduce new builtins Construct and ConstructFunction (in line with the Call and CallFunction builtins that we already have) as proper bottleneck for Construct and [[Construct]] on JSFunctions. Use these builtins to support passing NewTarget from C++ to JavaScript land. Long-term we want the CallConstructStub to be used for gathering feedback on entry to construction chain (i.e. the initial new Foo), and use the Construct builtins to do the actual work inside the construction chain (i.e. calling into super and stuff). BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -118 lines) Patch
M src/full-codegen/mips/full-codegen-mips.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M src/mips/builtins-mips.cc View 7 chunks +86 lines, -14 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +11 lines, -35 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 7 chunks +85 lines, -14 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 2 chunks +12 lines, -35 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
paul.l...
l-g-t-m for https://codereview.chromium.org/1359583002/
5 years, 3 months ago (2015-09-22 03:53:28 UTC) #2
Benedikt Meurer
5 years, 3 months ago (2015-09-22 03:58:05 UTC) #3
On 2015/09/22 03:53:28, paul.l... wrote:
> l-g-t-m for https://codereview.chromium.org/1359583002/

Merged, thanks a lot!

Powered by Google App Engine
This is Rietveld 408576698