Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1346893003: [es6] Use the correct ToPrimitive in the Date Constructor. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Use the correct ToPrimitive in the Date Constructor. This way we can finally remove the ES5 ToPrimitive builtin from runtime.js, and the Date Constructor now properly supports @@toPrimitive for the single argument case as well. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg,v8_linux_nosnap_dbg R=rossberg@chromium.org BUG=v8:4307 LOG=n Committed: https://crrev.com/90e1a0ddb328f566d444e25c26b0550ee56a67e8 Cr-Commit-Position: refs/heads/master@{#30832}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -27 lines) Patch
M src/contexts.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/date.js View 3 chunks +5 lines, -9 lines 0 comments Download
M src/macros.py View 1 chunk +0 lines, -4 lines 0 comments Download
M src/runtime.js View 5 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Benedikt Meurer
5 years, 3 months ago (2015-09-18 12:03:26 UTC) #1
Benedikt Meurer
Hey Andreas, Easy fix and cleanup. Please take a look. Thanks, Benedikt
5 years, 3 months ago (2015-09-18 12:03:54 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346893003/1
5 years, 3 months ago (2015-09-18 12:04:03 UTC) #4
rossberg
lgtm
5 years, 3 months ago (2015-09-18 12:08:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346893003/1
5 years, 3 months ago (2015-09-18 12:09:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 13:20:31 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 13:20:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90e1a0ddb328f566d444e25c26b0550ee56a67e8
Cr-Commit-Position: refs/heads/master@{#30832}

Powered by Google App Engine
This is Rietveld 408576698