Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1346883003: Added some missing includes, removed one include and removed an undef. (Closed)

Created:
5 years, 3 months ago by Henrik Grunell
Modified:
5 years, 3 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, chromoting-reviews_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added some missing includes, removed one include and removed an undef. Found this when working on removing WebRTC's dependency on Chromium. These updates makes the WebRTC Chromium FYI bots green. BUG=468375 TBR=sergeyu@chromium.org,nick@chromium.org Committed: https://crrev.com/cf1329463368a6268a492f57145f3c3c8d25c368 Cr-Commit-Position: refs/heads/master@{#349631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M content/renderer/media/mock_data_channel_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M jingle/notifier/listener/push_notifications_listen_task.h View 1 chunk +1 line, -0 lines 0 comments Download
M jingle/notifier/listener/push_notifications_subscribe_task.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/client/plugin/pepper_address_resolver.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/client/plugin/pepper_packet_socket_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/chromium_socket_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libjingle/overrides/init_webrtc.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Henrik Grunell
Nick: content/* Sergey: the rest.
5 years, 3 months ago (2015-09-17 16:20:22 UTC) #4
Henrik Grunell
On 2015/09/17 16:20:22, Henrik Grunell wrote: > Nick: content/* > Sergey: the rest. I'm going ...
5 years, 3 months ago (2015-09-18 07:39:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346883003/1
5 years, 3 months ago (2015-09-18 07:40:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 08:17:50 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 08:18:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf1329463368a6268a492f57145f3c3c8d25c368
Cr-Commit-Position: refs/heads/master@{#349631}

Powered by Google App Engine
This is Rietveld 408576698