chromeos/chromeos.gyp - Issue 1346843003: Refactor NetworkPortalDetector and NetworkPortalNotificationController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/chromeos.gyp

Issue 1346843003: Refactor NetworkPortalDetector and NetworkPortalNotificationController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: stub Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/net/network_portal_detector_impl.h ('K') | « chrome/browser/extensions/api/networking_config_chromeos_apitest_chromeos.cc ('k') | chromeos/network/portal_detector/network_portal_detector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/chromeos.gyp

diff --git a/chromeos/chromeos.gyp b/chromeos/chromeos.gyp

index d8015d90b7b03777a50ccac2a7b704c99838baea..4ccdfca9cdfb35a7f2a4a4bd23c0ed76c3983fab 100644

--- a/chromeos/chromeos.gyp

+++ b/chromeos/chromeos.gyp

@@ -419,6 +419,8 @@

'network/portal_detector/network_portal_detector.h',

'network/portal_detector/network_portal_detector_strategy.cc',

'network/portal_detector/network_portal_detector_strategy.h',

+ 'network/portal_detector/network_portal_detector_stub.cc',

+ 'network/portal_detector/network_portal_detector_stub.h',

'network/shill_property_handler.cc',

'network/shill_property_handler.h',

'network/shill_property_util.cc',

@@ -503,7 +505,6 @@

'network/network_configuration_handler_unittest.cc',

'network/network_connection_handler_unittest.cc',

'network/network_device_handler_unittest.cc',

- 'network/network_profile_handler_stub.h',

'network/network_sms_handler_unittest.cc',

'network/network_state_handler_unittest.cc',

'network/network_state_unittest.cc',