chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc - Issue 1346843003: Refactor NetworkPortalDetector and NetworkPortalNotificationController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

Issue 1346843003: Refactor NetworkPortalDetector and NetworkPortalNotificationController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: stub Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/net/network_portal_detector_impl.h ('K') | « chrome/browser/chromeos/net/network_portal_detector_impl.cc ('k') | chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

diff --git a/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc b/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

index 0d395b55ed9913865b53e24c878da6cf1cebc544..7a45b5e650f7660e5b0d16643f7e614df14541af 100644

--- a/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

+++ b/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

@@ -128,7 +128,8 @@ class NetworkPortalDetectorImplBrowserTest

base::Bind(&ErrorCallbackFunction));

network_portal_detector_ = new NetworkPortalDetectorImpl(

- g_browser_process->system_request_context());

+ g_browser_process->system_request_context(),

+ true /* create_notification_controller */);

NetworkPortalDetector::InitializeForTesting(network_portal_detector_);

network_portal_detector_->Enable(false /* start_detection */);

set_detector(network_portal_detector_->captive_portal_detector_.get());

@@ -151,12 +152,12 @@ class NetworkPortalDetectorImplBrowserTest

void SetIgnoreNoNetworkForTesting() {

network_portal_detector_->notification_controller_

- .SetIgnoreNoNetworkForTesting();

+ ->SetIgnoreNoNetworkForTesting();

}

const NetworkPortalWebDialog* GetDialog() const {

return network_portal_detector_->notification_controller_

- .GetDialogForTesting();

+ ->GetDialogForTesting();

}

private: