chrome/browser/resources/settings/downloads_page/downloads_page.html - Issue 1346823005: Elim cr_button from md-settings

Side by Side Diff: chrome/browser/resources/settings/downloads_page/downloads_page.html

Issue 1346823005: Elim cr_button from md-settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/certificate_manager_page/certificate_manager_page.html ('k') | chrome/browser/resources/settings/internet_page/internet_detail_page.css » ('j') | chrome/browser/resources/settings/search_page/search_page.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">

3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">

4 <link rel="import" href="chrome://resources/cr_elements/v1_0/cr_button/cr_button .html">

5 <link rel="import" href="chrome://resources/cr_elements/v1_0/cr_input/cr_input.h tml">	5 <link rel="import" href="chrome://resources/cr_elements/v1_0/cr_input/cr_input.h tml">

6 <link rel="import" href="chrome://md-settings/checkbox/checkbox.html">	6 <link rel="import" href="chrome://md-settings/checkbox/checkbox.html">

7	7

8 <dom-module id="cr-settings-downloads-page">	8 <dom-module id="cr-settings-downloads-page">

9 <link rel="import" type="css"	9 <link rel="import" type="css"

10 href="chrome://md-settings/settings_page/settings_page.css">	10 href="chrome://md-settings/settings_page/settings_page.css">

11 <link rel="import" type="css" href="downloads_page.css">	11 <link rel="import" type="css" href="downloads_page.css">

12 <template>	12 <template>

13 <div class="horizontal layout center">	13 <div class="horizontal layout center">

14 <div class="layout horizontal center">	14 <div class="layout horizontal center">

15 <div id="locationLabel" i18n-content="downloadLocation"></div>	15 <div id="locationLabel" i18n-content="downloadLocation"></div>

16 <cr-input id="downloadsPath" floating-label="false"	16 <cr-input id="downloadsPath" floating-label="false"

17 value="{{prefs.download.default_directory.value}}"	17 value="{{prefs.download.default_directory.value}}"

18 readonly aria-labelledby="locationLabel">	18 readonly aria-labelledby="locationLabel">

19 </cr-input>	19 </cr-input>

20 </div>	20 </div>

21 <cr-button id="changeDownloadsPath" on-click="selectDownloadLocation_"	21 <paper-button id="changeDownloadsPath" on-tap="selectDownloadLocation_"
	Dan Beam 2015/09/22 17:22:47 did we decide on-tap instead of on-click yet? did we decide on-tap instead of on-click yet? stevenjb 2015/09/22 17:36:29 I thought we did. Maybe discuss in today's meeting Show quoted text On 2015/09/22 17:22:47, Dan Beam wrote: > did we decide on-tap instead of on-click yet? I thought we did. Maybe discuss in today's meeting? stevenjb 2015/09/22 23:00:18 Confirmed on-tap in today's Settings meeting. Show quoted text On 2015/09/22 17:36:29, stevenjb wrote: > On 2015/09/22 17:22:47, Dan Beam wrote: > > did we decide on-tap instead of on-click yet? > > I thought we did. Maybe discuss in today's meeting? Confirmed on-tap in today's Settings meeting.
22 i18n-content="changeDownloadLocation">	22 i18n-content="changeDownloadLocation">

23 </cr-button>	23 </paper-button>

24 </div>	24 </div>

25 <cr-settings-checkbox pref="{{prefs.download.prompt_for_download}}"	25 <cr-settings-checkbox pref="{{prefs.download.prompt_for_download}}"

26 i18n-values="label:promptForDownload">	26 i18n-values="label:promptForDownload">

27 </cr-settings-checkbox>	27 </cr-settings-checkbox>

28 </template>	28 </template>

29 <script src="downloads_page.js"></script>	29 <script src="downloads_page.js"></script>

30 </dom-module>	30 </dom-module>

OLD	NEW