Issue 13468018: Speculatively revert r192702 to fix win interactive_ui_tests failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13468018: Speculatively revert r192702 to fix win interactive_ui_tests failures. (Closed)

Created:
7 years, 8 months ago by dcheng

Modified:
7 years, 8 months ago

Reviewers:
msw

CC:
chromium-reviews, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Speculatively revert r192702 to fix win interactive_ui_tests failures. DragAllToSeparateWindowAndCancel started failing in r192698:r192702. > Use Views Omnibox and Textfields by default on non-Aura Win. > > Enable by default to expand dogfooding for release. > Users can --disable-views-textfield via commandline or about:flags. > > File related Chrome UI (not web content) bugs against msw. Known issues: > http://crbug.com/?q=owner=msw@chromium.org > > BUG=131660 > TEST=Textfields work well enough on non-Aura Win. > R=sky@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/12330177 TBR=msw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192766

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	ui/views/controls/textfield/textfield.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

msw

7 years, 8 months ago (2013-04-07 17:46:36 UTC) #3

Message was sent while issue was closed.

LGTM; I filed http://crrev.com/227444; thanks and sorry for the inconvenience.