Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 13468015: Make gyp work with MingW32 (Closed)

Created:
7 years, 8 months ago by haitao.feng
Modified:
7 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Make gyp work with MingW32 Committed: http://code.google.com/p/v8/source/detail?r=14257

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M test/cctest/test-platform-win32.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 1 chunk +15 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haitao.feng
Here is the instruction to "make ia32.release" with this patch. 1) Install MingW32 and mysys ...
7 years, 8 months ago (2013-04-03 09:07:45 UTC) #1
Jakob Kummerow
LGTM, landing. Thanks for this contribution!
7 years, 8 months ago (2013-04-15 08:32:04 UTC) #2
Jakob Kummerow
7 years, 8 months ago (2013-04-15 08:33:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r14257 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698