Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 13468010: Revert Skia to use -02. (Closed)

Created:
7 years, 8 months ago by djsollen
Modified:
7 years, 8 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert Skia to use -02. There was no clear speed improvement and the increase in binary size was substantial. Committed: http://code.google.com/p/skia/source/detail?r=8492 Committed: https://code.google.com/p/skia/source/detail?r=8494 Committed: https://code.google.com/p/skia/source/detail?r=8539

Patch Set 1 #

Patch Set 2 : revert #

Patch Set 3 : reapply #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gyp/common_conditions.gypi View 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
djsollen
7 years, 8 months ago (2013-04-02 17:32:01 UTC) #1
borenet
LGTM
7 years, 8 months ago (2013-04-02 17:35:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/13468010/1
7 years, 8 months ago (2013-04-02 17:36:27 UTC) #3
commit-bot: I haz the power
Change committed as 8492
7 years, 8 months ago (2013-04-02 17:36:33 UTC) #4
djsollen
Committed patchset #2 manually as r8494 (presubmit successful).
7 years, 8 months ago (2013-04-02 18:14:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/13468010/4
7 years, 8 months ago (2013-04-04 19:21:12 UTC) #6
commit-bot: I haz the power
Retried try job too often on Skia_MacMini_10_8_Float_Compile_Release_32_Trybot for step(s) BuildBench, BuildGM, BuildMost, BuildSkiaBaseLibs, BuildTests, BuildTools ...
7 years, 8 months ago (2013-04-04 19:37:09 UTC) #7
djsollen
7 years, 8 months ago (2013-04-04 19:43:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r8539 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698