Show only the settings pages for new managed users

chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/sync_promo/sync_promo_ui.h"
 
 #include "base/command_line.h"
 #include "base/prefs/pref_service.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
@@ skipping 115 matching lines @@
 #else
 
   // Don't bother if we don't have any kind of network connection.
   if (net::NetworkChangeNotifier::IsOffline())
     return false;
 
   // Don't show if the profile is an incognito.
   if (profile->IsOffTheRecord())
     return false;
 
+  // Don't show for managed users.

[Dan Beam, 2013/04/03 23:39:20]

nit: managed profiles

[Sergiu, 2013/04/04 09:02:55]

Done.

+  if (profile->GetPrefs()->GetBoolean(prefs::kProfileIsManaged))

[Dan Beam, 2013/04/03 23:39:20]

do you want to disable the promo based on whether the *profile* is managed or
whether *sync* is managed?  if it's sync, you should probably use

  if (!profile->IsSyncAccessible())

instead

[Dan Beam, 2013/04/04 00:01:45]

er, if (profile->IsSyncAccessible()) I mean

[Dan Beam, 2013/04/04 01:12:59]

... and I'm going to go drink more coffee

[Sergiu, 2013/04/04 09:02:55]

It is for managed users (see the referenced bug for our definition of a managed
user).

+    return false;
+
   // Display the signin promo if the user is not signed in.
   SigninManager* signin = SigninManagerFactory::GetForProfile(
       profile->GetOriginalProfile());
   return !signin->AuthInProgress() && signin->IsSigninAllowed() &&
       signin->GetAuthenticatedUsername().empty();
 #endif
 }
 
 // static
 void SyncPromoUI::RegisterUserPrefs(PrefRegistrySyncable* registry) {
@@ skipping 160 matching lines @@
       g_force_web_based_signin_flow;
 #else
   return false;
 #endif
 }
 
 // static
 void SyncPromoUI::ForceWebBasedSigninFlowForTesting(bool force) {
   g_force_web_based_signin_flow = force;
 }