Make drawRect preserve vertex attrib state and push/pop the geom sources.

Make drawRect preserve vertex attrib state and push/pop the geom sources.

Also, add some balancing calls for setIndexSource*()
Committed: https://code.google.com/p/skia/source/detail?r=8499

[bsalomon, 2013-04-02 14:25:42]

Motivation: I want to add a surface->surface GrDT call that can be buffered in
the GrIODB. The default implementation will check if the src is a texture and
the dst is a RT and if so draw a rect. Therefore, I wanted drawRect's
interaction with geometry sources and attribs to be better specified.

The balancing resetIndexSource calls aren't of paramount importance. The index
buffers are long lived so holding a ref on them in the draw target isn't likely
to make them stay alive any longer. But it seemed better to release the refs
after we're done with drawing with them.

[jvanverth1, 2013-04-02 18:45:35]

Looks reasonable, just one question:

https://codereview.chromium.org/13468004/diff/2002/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

https://codereview.chromium.org/13468004/diff/2002/src/gpu/GrDrawTarget.h#new...
src/gpu/GrDrawTarget.h:553: * state regardless of ASRInit value.
Maybe I'm misunderstanding. What happens if the pushed geometry doesn't match
the default vertex attribs? Why not use  AutoVertexAttribRestore?

[bsalomon, 2013-04-02 18:47:39]

https://codereview.chromium.org/13468004/diff/2002/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

https://codereview.chromium.org/13468004/diff/2002/src/gpu/GrDrawTarget.h#new...
src/gpu/GrDrawTarget.h:553: * state regardless of ASRInit value.
On 2013/04/02 18:45:35, JimVV wrote:
> Maybe I'm misunderstanding. What happens if the pushed geometry doesn't match
> the default vertex attribs? Why not use  AutoVertexAttribRestore?

It's already using an AutoStateRestore. So it will restore the entire
GrDrawState that was previously set including its vertex attribs.

[jvanverth1, 2013-04-02 20:47:55]

lgtm

[bsalomon, 2013-04-02 21:00:21]

Committed patchset #2 manually as r8499 (presubmit successful).