net/http/http_cache_transaction.cc - Issue 1346793002: HTTP cache: Add tests to improve coverage of AddTruncatedFlag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_cache_transaction.cc

Issue 1346793002: HTTP cache: Add tests to improve coverage of AddTruncatedFlag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move helper function Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_cache_transaction.cc

diff --git a/net/http/http_cache_transaction.cc b/net/http/http_cache_transaction.cc

index 450cc450eebc45ce14a61c59e0b4b301202c4f1b..db3f4968911b47ec29167190cf429a69007e00d7 100644

--- a/net/http/http_cache_transaction.cc

+++ b/net/http/http_cache_transaction.cc

@@ -1875,7 +1875,7 @@ int HttpCache::Transaction::DoCacheWriteDataComplete(int result) {

// We want to ignore errors writing to disk and just keep reading from

// the network.

result = write_len_;

- } else if (!done_reading_ && entry_) {

+ } else if (!done_reading_ && entry_ && (!partial_ || truncated_)) {

int current_size = entry_->disk_entry->GetDataSize(kResponseContentIndex);

int64 body_size = response_.headers->GetContentLength();

if (body_size >= 0 && body_size <= current_size)

« no previous file with comments | « no previous file | net/http/http_cache_unittest.cc » ('j') | no next file with comments »