Stop running pub get at gclient sync time and fix build bugs

mojo/dart/embedder/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # embedder specific template rules.
 import("embedder.gni")
 
 source_set("dart_controller_no_snapshot") {
   sources = [
     "$target_gen_dir/dart_embedder_patch_resources.cc",
@@ skipping 22 matching lines @@
   if (is_android) {
     sources += [ "io/internet_address_android.cc" ]
   }
 
   deps = [
     ":dart_embedder_packages",
     ":generate_dart_embedder_patch_resources_cc",
     ":generate_dart_embedder_service_isolate_resources_cc",
     "//base",
     "//base:i18n",
-    "//dart/runtime:libdart",
-    "//dart/runtime/bin:libdart_embedder_noio",
-    "//third_party/dart-pkg",
+    "//mojo/public/third_party/dart/runtime:libdart",
+    "//mojo/public/third_party/dart/runtime/bin:libdart_embedder_noio",
+    "//mojo/public/third_party/dart-pkg",
     "//mojo/message_pump",
     "//mojo/public/c/system",
     "//mojo/public/cpp/system",
     "//mojo/services/network/public/interfaces",
     "//tonic",
   ]
 
   defines = []
   if (is_debug) {
     defines += [ "DEBUG" ]
@@ skipping 95 matching lines @@
     "//mojo/dart/embedder/vmservice/main.dart",
     "//mojo/dart/embedder/vmservice/resources.dart",
     "//mojo/dart/embedder/vmservice/server.dart",
   ]
   root_prefix = "//mojo/dart/embedder/"
   input_directory = "$root_out_dir/observatory/deployed/web/"
   output = "$target_gen_dir/dart_embedder_service_isolate_resources.cc"
   table_name = "dart_embedder_service_isolate"
 }
 
-observatory_sources_gypi =
-    exec_script("../../../dart/tools/gypi_to_gn.py",
-                [ rebase_path(
-                    "//dart/runtime/observatory/observatory_sources.gypi") ],
-                "scope",
-                [ "//dart/runtime/observatory/observatory_sources.gypi" ])
+observatory_sources_gypi = exec_script(
+        "../../public/third_party/dart/tools/gypi_to_gn.py",
+        [ rebase_path(
+            "//mojo/public/third_party/dart/runtime/observatory/observatory_sources.gypi") ],
+        "scope",
+        [ "//mojo/public/third_party/dart/runtime/observatory/observatory_sources.gypi" ])
 
 copy("copy_observatory") {
   sources = rebase_path(observatory_sources_gypi.sources,
                         "",
-                        "../../../dart/runtime/observatory")
+                        "../../public/third_party/dart/runtime/observatory")
   outputs = [
     "$root_gen_dir/observatory_copy/{{source_root_relative_dir}}/{{source_file_part}}",
   ]
 }
 
 action("write_observatory_pubspec_yaml") {
   deps = [
     ":copy_observatory",
   ]
 
-  script = "//dart/tools/observatory_tool.py"
+  script = "//mojo/public/third_party/dart/tools/observatory_tool.py"
 
   inputs = [
-    rebase_path("//dart/runtime/observatory/pubspec.yaml"),
+    rebase_path(
+        "//mojo/public/third_party/dart/runtime/observatory/pubspec.yaml"),
   ]
 
   args = [
     "--silent=True",
     "--pub-executable",
     rebase_path("//third_party/dart-sdk/dart-sdk/bin/pub"),
     "--directory",
-    rebase_path("$root_gen_dir/observatory_copy/dart/runtime/observatory/"),
+    rebase_path(
+        "$root_gen_dir/observatory_copy/mojo/public/third_party/dart/runtime/observatory/"),
     "--command",
     "rewrite",
-    rebase_path("//dart/runtime/observatory/pubspec.yaml"),
     rebase_path(
-        "$root_gen_dir/observatory_copy/dart/runtime/observatory/pubspec.yaml"),
+        "//mojo/public/third_party/dart/runtime/observatory/pubspec.yaml"),
+    rebase_path(
+        "$root_gen_dir/observatory_copy/mojo/public/third_party/dart/runtime/observatory/pubspec.yaml"),
     "../../third_party/",
-    rebase_path("../../../dart/third_party/"),
+    rebase_path("../../public/third_party/dart/third_party/"),
   ]
 
   outputs = [
-    "$root_gen_dir/observatory_copy/dart/runtime/observatory/pubspec.yaml",
+    "$root_gen_dir/observatory_copy/mojo/public/third_party/dart/runtime/observatory/pubspec.yaml",
   ]
 }
 
 action("copy_observatory_deps") {
   deps = [
     ":write_observatory_pubspec_yaml",
   ]
 
-  script = "//dart/tools/observatory_tool.py"
+  script = "//mojo/public/third_party/dart/tools/observatory_tool.py"
 
   inputs = [
     script,
-    "$root_gen_dir/observatory_copy/dart/runtime/observatory/pubspec.yaml",
+    "$root_gen_dir/observatory_copy/mojo/public/third_party/dart/runtime/observatory/pubspec.yaml",
   ]
 
   args = [
     "--silent=True",
     "--pub-executable",
     rebase_path("//third_party/dart-sdk/dart-sdk/bin/pub"),
     "--directory",
-    rebase_path("$root_gen_dir/observatory_copy/dart/runtime/observatory/"),
+    rebase_path(
+        "$root_gen_dir/observatory_copy/mojo/public/third_party/dart/runtime/observatory/"),
     "--command",
     "get",
   ]
 
   outputs = [
-    "$root_gen_dir/observatory_copy/dart/runtime/observatory/pubspec.lock",
+    "$root_gen_dir/observatory_copy/mojo/public/third_party/dart/runtime/observatory/pubspec.lock",
   ]
 }
 
 action("pub_build_observatory") {
-  sources =
-      rebase_path(observatory_sources_gypi.sources,
-                  "",
-                  "$root_gen_dir/observatory_copy/dart/runtime/observatory")
+  sources = rebase_path(
+          observatory_sources_gypi.sources,
+          "",
+          "$root_gen_dir/observatory_copy/mojo/public/third_party/dart/runtime/observatory")
 
   deps = [
     ":copy_observatory",
     ":copy_observatory_deps",
   ]
 
-  script = "//dart/tools/observatory_tool.py"
+  script = "//mojo/public/third_party/dart/tools/observatory_tool.py"
 
   inputs = [
     script,
   ]
   inputs += sources
 
   args = [
     "--silent=True",
     "--pub-executable",
     rebase_path("//third_party/dart-sdk/dart-sdk/bin/pub"),
     "--directory",
-    rebase_path("$root_gen_dir/observatory_copy/dart/runtime/observatory/"),
+    rebase_path(
+        "$root_gen_dir/observatory_copy/mojo/public/third_party/dart/runtime/observatory/"),
     "--command",
     "build",
     rebase_path("$root_out_dir/observatory/build"),
   ]
 
   outputs = [
     "$root_out_dir/observatory/build/web/index.html",
     "$root_out_dir/observatory/build/web/index.html.polymer.bootstrap.dart.js",
   ]
 }
 
 action("deploy_observatory") {
   deps = [
     ":pub_build_observatory",
   ]
 
-  script = "//dart/tools/observatory_tool.py"
+  script = "//mojo/public/third_party/dart/tools/observatory_tool.py"
 
   inputs = [
     script,
     "$root_out_dir/observatory/build/web/index.html",
     "$root_out_dir/observatory/build/web/index.html.polymer.bootstrap.dart.js",
   ]
 
   args = [
     "--silent=True",
     "--pub-executable",
     rebase_path("//third_party/dart-sdk/dart-sdk/bin/pub"),
     "--directory",
     rebase_path("$root_out_dir/observatory"),
     "--command",
     "deploy",
   ]
 
   outputs = [
     "$root_out_dir/observatory/deployed/web/index.html",
     "$root_out_dir/observatory/deployed/web/index.html.polymer.bootstrap.dart.js",
   ]
 }
 
 action("generate_snapshot_bin") {
   deps = [
-    "//dart/runtime/bin:gen_snapshot($host_toolchain)",
+    "//mojo/public/third_party/dart/runtime/bin:gen_snapshot($host_toolchain)",
     ":dart_embedder_packages",
   ]
   inputs = [
     "snapshot.dart",
-    "//dart/runtime/tools/create_snapshot_bin.py",
+    "//mojo/public/third_party/dart/runtime/tools/create_snapshot_bin.py",
     "//mojo/dart/embedder/builtin.dart",
     "//mojo/dart/embedder/packages.dart",
     "//mojo/public/dart/mojo/sdk_ext/internal.dart",
     "//mojo/public/dart/mojo/sdk_ext/src/handle_watcher.dart",
     "//mojo/public/dart/mojo/sdk_ext/src/natives.dart",
     "//mojo/public/dart/mojo/sdk_ext/src/timer_queue.dart",
   ]
   vm_isolate_snapshot = "$target_gen_dir/vm_isolate_snapshot.bin"
   isolate_snapshot = "$target_gen_dir/isolate_snapshot.bin"
   outputs = [
     vm_isolate_snapshot,
     isolate_snapshot,
   ]
 
   gen_snapshot_dir =
       get_label_info("//dart/runtime/bin:gen_snapshot($host_toolchain)",
                      "root_out_dir")
-  script = "//dart/runtime/tools/create_snapshot_bin.py"
+  script = "//mojo/public/third_party/dart/runtime/tools/create_snapshot_bin.py"
   builtin_path = rebase_path("//mojo/dart/embedder/builtin.dart")
   internal_path = rebase_path("//mojo/public/dart/mojo/sdk_ext/internal.dart")
-  io_path = rebase_path("//dart/sdk/lib/io/io.dart")
+  io_path = rebase_path("//mojo/public/third_party/dart/sdk/lib/io/io.dart")
 
   embedder_packages_path = rebase_path("//mojo/dart/embedder/packages.dart")
   embedder_package_application_path = rebase_path(
           "$root_gen_dir/dart_embedder_packages/mojo/public/dart/mojo/lib/application.dart")
   embedder_package_bindings_path = rebase_path(
           "$root_gen_dir/dart_embedder_packages/mojo/public/dart/mojo/lib/bindings.dart")
   embedder_package_core_path = rebase_path(
           "$root_gen_dir/dart_embedder_packages/mojo/public/dart/mojo/lib/core.dart")
   url_mappings_script =
       rebase_path("//mojo/dart/embedder/tools/dart_embedder_url_mappings.py")
@@ skipping 43 matching lines @@
            "--url_mapping=dart:_mojo/bindings.dart,$embedder_package_bindings_path",
            "--url_mapping=dart:_mojo/core.dart,$embedder_package_core_path",
          ] + embedder_mojom_url_mappings
 }
 
 action("generate_snapshot_file") {
   deps = [
     ":generate_snapshot_bin",
   ]
   inputs = [
-    "//dart/runtime/tools/create_snapshot_file.py",
+    "//mojo/public/third_party/dart/runtime/tools/create_snapshot_file.py",
     "//mojo/dart/embedder/snapshot.cc.tmpl",
     "$target_gen_dir/vm_isolate_snapshot.bin",
     "$target_gen_dir/isolate_snapshot.bin",
   ]
   output = "$root_gen_dir/dart_snapshot.cc"
   outputs = [
     output,
   ]
 
-  script = "//dart/runtime/tools/create_snapshot_file.py"
+  script =
+      "//mojo/public/third_party/dart/runtime/tools/create_snapshot_file.py"
   args = [
     "--vm_input_bin",
     rebase_path("$target_gen_dir/vm_isolate_snapshot.bin"),
     "--input_bin",
     rebase_path("$target_gen_dir/isolate_snapshot.bin"),
     "--input_cc",
     rebase_path("//mojo/dart/embedder/snapshot.cc.tmpl"),
     "--output",
     rebase_path(output),
   ]
 }
 
 source_set("dart_snapshot_cc") {
   sources = [
     "$root_gen_dir/dart_snapshot.cc",
   ]
 
   deps = [
     ":generate_snapshot_file",
   ]
 }