Stop running pub get at gclient sync time and fix build bugs

DEPS

 # This file is automatically processed to create .DEPS.git which is the file
 # that gclient uses under git.
 #
 # See http://code.google.com/p/chromium/wiki/UsingGit
 #
 # To test manually, run:
 #   python tools/deps2git/deps2git.py -o .DEPS.git -w <gclientdir>
 # where <gcliendir> is the absolute path to the directory containing the
 # .gclient file (the parent of 'src').
 #
@@ skipping 12 matching lines @@
   'v8_revision': '230d131d173ab2d60291d303177bc04ec3f6e519',
   'angle_revision': 'bdd419f9f5b006e913606e7363125942c8ae06bc',
   'buildtools_revision': '565d04e8741429fb1b4f26d102f2c6c3b849edeb',
   'dart_revision': 'cab003366785773ace16b5305ac1f33c228cac54',
   'dart_observatory_packages_revision': 'cdc4b3d4c15b9c0c8e7702dff127b440afbb7485',
   'pdfium_revision': 'ae4256f45df69bbfdf722a6ec17e1e851911ae4e',
   'boringssl_revision': '642f1498d056dbba3e50ed5a232ab2f482626dec',
   'lss_revision': '6f97298fe3794e92c8c896a6bc06e0b36e4c3de3',
   'nss_revision': 'bb4e75a43d007518ae7d618665ea2f25b0c60b63',
   'nacl_revision': '8071f876e10f96da879853a7705d9c5aba378839',
-  'archive_dart_revision': '07ffd98c5403b7f9ae067b57dc9487611be420f5',
-  'args_dart_revision': 'e0e8377412ee6cd6a5a4a8632848181c1db91f44',
-  'box2d_dart_revision': 'c5e65d9546275e78ad2a1d51b459e7638f6e4323',
-  'cassowary_dart_revision': '7e5afc5b3956a18636d5b37b1dcba1705865564b',
+  # Below is the list of third party Dart package dependencies.
+  'args_dart_revision': '@0.13.2',

[jamesr, 2015/09/16 22:32:52]

what are these @ annotations referring to? git tags?

[Cutch, 2015/09/17 20:55:23]

These annotations are gone now but yes, they refer to git tags.

+  'async_dart_revision': '@1.3.0',
+  'barback_dart_revision': '@0.15.2+6',
+  'charcode_dart_revision': '@1.1.0',
   'collection_dart_revision': '79ebc6fc2dae581cb23ad50a5c600c1b7dd132f8',
   'crypto_dart_revision': 'd4558dea1639e5ad2a41d045265b8ece270c2d90',
-  'newton_dart_revision': '9fbe5fbac809246f7ace4176feca13bdf731e393',
-  'path_dart_revision': '2f3dcdec32011f1bc41194ae3640d6d9292a7096',
-  'quiver_dart_revision': '6bab7dec34189eee579178eb16d3063c8ae69031',
-  'source_span_dart_revision': '5c6c13f62fc111adaace3aeb4a38853d64481d06',
-  'string_scanner_dart_revision': '9f00056b32f41efc376adecfb696a01bc7c593d7',
-  'vector_math_dart_revision': '65915583f7aa606cb47ed265f853c18c60102b81',
-  'yaml_dart_revision': 'd8c1ce75edf051ea1d5583b24474f8656abb4920',
+  'csslib_dart_revision': '@0.12.1',
+  'glob_dart_revision': '@1.0.5',
+  'html_dart_revision': '@0.12.2',
+  'http_multi_server_dart_revision': '@1.3.2',
+  'http_parser_dart_revision': '8b179e36aba985208e4c5fb15cfddd386b6370a4',
+  'logging_dart_revision': '@0.11.1+1',
+  'matcher_dart_revision': '@0.12.0+1',
+  'mime_dart_revision': '@0.9.3',
+  'package_config_dart_revision': '@0.1.3',
+  'path_dart_revision': '@1.3.6',
+  'plugin_dart_revision': '@0.1.0',
+  'pool_dart_revision': '@1.1.0',
+  'pub_semver_dart_revision': '@1.2.1',
+  'shelf_dart_revision': '@0.6.2+1',
+  'shelf_static_dart_revision': '@0.2.3+1',
+  'shelf_web_socket_dart_revision': '@0.0.1+4',
+  'source_maps_dart_revision': '@0.10.1',
+  'source_map_stack_trace_dart_revision': '@1.0.4',
+  'source_span_dart_revision': '@1.1.6',
+  'stack_trace_dart_revision': '@1.4.1',
+  'string_scanner_dart_revision': '@0.1.4',
+  'test_dart_revision': '@0.12.4+7',
+  'unittest_dart_revision': '@0.11.6+1',
+  'utf_dart_revision': '1f55027068759e2d52f2c12de6a57cce5f3c5ee6',
+  'watcher_dart_revision': '@0.9.7',
+  'yaml_dart_revision': '@2.1.5',
 }
 
 # Only these hosts are allowed for dependencies in this DEPS file.
 # If you need to add a new host, contact chrome infrastructure team.
 allowed_hosts = [
   'boringssl.googlesource.com',
   'chromium.googlesource.com',
   'pdfium.googlesource.com',
 ]
 
@@ skipping 12 matching lines @@
 
   'src/third_party/icu':
    Var('chromium_git') + '/chromium/deps/icu.git' + '@' + 'c3f79166089e5360c09e3053fce50e6e296c3204',
 
   'src/tools/grit':
     Var('chromium_git') + '/external/grit-i18n.git' + '@' + 'c1b1591a05209c1ad467e845ba8543c22f9072af', # from svn revision 189
 
   'src/v8':
     Var('chromium_git') + '/v8/v8.git' + '@' +  Var('v8_revision'),
 
-  'src/dart':
+  'src/mojo/public/third_party/dart':
     Var('chromium_git') + '/external/github.com/dart-lang/sdk.git' + '@' + Var('dart_revision'),
 
-  'src/dart/third_party/observatory_pub_packages':
+  'src/mojo/public/third_party/dart/third_party/observatory_pub_packages':

[jamesr, 2015/09/16 22:32:52]

as we discussed in person DEPSing stuff into mojo/public/.. will break the way
we currently package and distribute the mojo sdk, so these need to be checked in
for now.

[Cutch, 2015/09/17 20:55:23]

Done.

     Var('chromium_git') +
     '/external/github.com/dart-lang/observatory_pub_packages' + '@' +
     Var('dart_observatory_packages_revision'),
 
   'src/third_party/skia':
    Var('chromium_git') + '/skia.git' + '@' +  Var('skia_revision'),
 
   'src/third_party/yasm/source/patched-yasm':
    Var('chromium_git') + '/chromium/deps/yasm/patched-yasm.git' + '@' + '4671120cd8558ce62ee8672ebf3eb6f5216f909b',
 
@@ skipping 14 matching lines @@
 
   'src/third_party/boringssl/src':
    'https://boringssl.googlesource.com/boringssl.git' + '@' +  Var('boringssl_revision'),
 
   'src/third_party/requests/src':
     Var('chromium_git') + '/external/github.com/kennethreitz/requests.git' + '@' + 'f172b30356d821d180fa4ecfa3e71c7274a32de4',
 
   'src/native_client':
     Var('chromium_git') + '/native_client/src/native_client.git' + '@' + Var('nacl_revision'),
 
-  'src/third_party/dart-pkg/archive':
-    Var('chromium_git') + '/external/github.com/brendan-duncan/archive.git' + '@' + Var('archive_dart_revision'),
+  'src/mojo/public/third_party/dart-pkg/args':
+    Var('chromium_git') + '/external/github.com/dart-lang/args.git' + Var('args_dart_revision'),
 
-  'src/third_party/dart-pkg/args':
-    Var('chromium_git') + '/external/github.com/dart-lang/args.git' + '@' + Var('args_dart_revision'),
+  'src/mojo/public/third_party/dart-pkg/async':
+    Var('chromium_git') + '/external/github.com/dart-lang/async.git' + Var('async_dart_revision'),
 
-  'src/third_party/dart-pkg/box2d':
-    Var('chromium_git') + '/external/github.com/google/box2d.dart.git' + '@' + Var('box2d_dart_revision'),
+  'src/mojo/public/third_party/dart-pkg/barback':
+    Var('chromium_git') + '/external/github.com/dart-lang/barback.git' + Var('barback_dart_revision'),
 
-  'src/third_party/dart-pkg/cassowary':
-    Var('chromium_git') + '/external/github.com/domokit/cassowary.git' + '@' + Var('cassowary_dart_revision'),
+  'src/mojo/public/third_party/dart-pkg/charcode':
+    Var('chromium_git') + '/external/github.com/dart-lang/charcode.git' + Var('charcode_dart_revision'),
 
-  'src/third_party/dart-pkg/collection':
+  'src/mojo/public/third_party/dart-pkg/collection':
     Var('chromium_git') + '/external/github.com/dart-lang/collection.git' + '@' + Var('collection_dart_revision'),
 
-  'src/third_party/dart-pkg/crypto':
+  'src/mojo/public/third_party/dart-pkg/crypto':
     Var('chromium_git') + '/external/github.com/dart-lang/crypto.git' + '@' + Var('crypto_dart_revision'),
 
-  'src/third_party/dart-pkg/newton':
-    Var('chromium_git') + '/external/github.com/domokit/newton.git' + '@' + Var('newton_dart_revision'),
+  'src/mojo/public/third_party/dart-pkg/csslib':
+    Var('chromium_git') + '/external/github.com/dart-lang/csslib.git' + Var('csslib_dart_revision'),
 
-  'src/third_party/dart-pkg/path':
-    Var('chromium_git') + '/external/github.com/dart-lang/path.git' + '@' + Var('path_dart_revision'),
+  'src/mojo/public/third_party/dart-pkg/glob':
+    Var('chromium_git') + '/external/github.com/dart-lang/glob.git' + Var('glob_dart_revision'),
 
-  'src/third_party/dart-pkg/quiver':
-    Var('chromium_git') + '/external/github.com/google/quiver-dart.git' + '@' + Var('quiver_dart_revision'),
+  'src/mojo/public/third_party/dart-pkg/html':
+    Var('chromium_git') + '/external/github.com/dart-lang/html.git' + Var('html_dart_revision'),
 
-  'src/third_party/dart-pkg/source_span':
-    Var('chromium_git') + '/external/github.com/dart-lang/source_span.git' + '@' + Var('source_span_dart_revision'),
+  'src/mojo/public/third_party/dart-pkg/http_multi_server':
+    Var('chromium_git') + '/external/github.com/dart-lang/http_multi_server.git' + Var('http_multi_server_dart_revision'),
 
-  'src/third_party/dart-pkg/string_scanner':
-    Var('chromium_git') + '/external/github.com/dart-lang/string_scanner.git' + '@' + Var('string_scanner_dart_revision'),
+  'src/mojo/public/third_party/dart-pkg/http_parser':
+    Var('chromium_git') + '/external/github.com/dart-lang/http_parser.git' + '@' + Var('http_parser_dart_revision'),
 
-  'src/third_party/dart-pkg/vector_math':
-    Var('chromium_git') + '/external/github.com/google/vector_math.dart.git' + '@' + Var('vector_math_dart_revision'),
+  'src/mojo/public/third_party/dart-pkg/logging':
+    Var('chromium_git') + '/external/github.com/dart-lang/logging.git' + Var('logging_dart_revision'),
 
-  'src/third_party/dart-pkg/yaml':
-    Var('chromium_git') + '/external/github.com/dart-lang/yaml.git' + '@' + Var('yaml_dart_revision'),
+  'src/mojo/public/third_party/dart-pkg/matcher':
+    Var('chromium_git') + '/external/github.com/dart-lang/matcher.git' + Var('matcher_dart_revision'),
+
+  'src/mojo/public/third_party/dart-pkg/mime':
+    Var('chromium_git') + '/external/github.com/dart-lang/mime.git' + Var('mime_dart_revision'),
+
+  'src/mojo/public/third_party/dart-pkg/package_config':
+    Var('chromium_git') + '/external/github.com/dart-lang/package_config.git' + Var('package_config_dart_revision'),
+
+  'src/mojo/public/third_party/dart-pkg/path':
+    Var('chromium_git') + '/external/github.com/dart-lang/path.git' + Var('path_dart_revision'),
+
+  'src/mojo/public/third_party/dart-pkg/plugin':
+    Var('chromium_git') + '/external/github.com/dart-lang/plugin.git' + Var('plugin_dart_revision'),
+
+  'src/mojo/public/third_party/dart-pkg/pool':
+    Var('chromium_git') + '/external/github.com/dart-lang/pool.git' + Var('pool_dart_revision'),
+
+  'src/mojo/public/third_party/dart-pkg/pub_semver':
+    Var('chromium_git') + '/external/github.com/dart-lang/pub_semver.git' + Var('pub_semver_dart_revision'),
+
+  'src/mojo/public/third_party/dart-pkg/shelf':
+    Var('chromium_git') + '/external/github.com/dart-lang/shelf.git' + Var('shelf_dart_revision'),
+
+  'src/mojo/public/third_party/dart-pkg/shelf_static':
+    Var('chromium_git') + '/external/github.com/dart-lang/shelf_static.git' + Var('shelf_static_dart_revision'),
+
+  'src/mojo/public/third_party/dart-pkg/shelf_web_socket':
+    Var('chromium_git') + '/external/github.com/dart-lang/shelf_web_socket.git' + Var('shelf_web_socket_dart_revision'),
+
+  'src/mojo/public/third_party/dart-pkg/source_maps':
+    Var('chromium_git') + '/external/github.com/dart-lang/source_maps.git' + Var('source_maps_dart_revision'),
+
+  'src/mojo/public/third_party/dart-pkg/source_map_stack_trace':
+    Var('chromium_git') + '/external/github.com/dart-lang/source_map_stack_trace.git' + Var('source_map_stack_trace_dart_revision'),
+
+  'src/mojo/public/third_party/dart-pkg/source_span':
+    Var('chromium_git') + '/external/github.com/dart-lang/source_span.git' + Var('source_span_dart_revision'),
+
+  'src/mojo/public/third_party/dart-pkg/stack_trace':
+    Var('chromium_git') + '/external/github.com/dart-lang/stack_trace.git' + Var('stack_trace_dart_revision'),
+
+  'src/mojo/public/third_party/dart-pkg/string_scanner':
+    Var('chromium_git') + '/external/github.com/dart-lang/string_scanner.git' + Var('string_scanner_dart_revision'),
+
+  'src/mojo/public/third_party/dart-pkg/test':
+    Var('chromium_git') + '/external/github.com/dart-lang/test.git' + Var('test_dart_revision'),
+
+  'src/mojo/public/third_party/dart-pkg/unittest':
+    Var('chromium_git') + '/external/github.com/dart-lang/test.git' + Var('unittest_dart_revision'),
+
+  'src/mojo/public/third_party/dart-pkg/utf':
+    Var('chromium_git') + '/external/github.com/dart-lang/utf.git' + '@' + Var('utf_dart_revision'),
+
+  'src/mojo/public/third_party/dart-pkg/watcher':
+    Var('chromium_git') + '/external/github.com/dart-lang/watcher.git' + Var('watcher_dart_revision'),
+
+  'src/mojo/public/third_party/dart-pkg/yaml':
+    Var('chromium_git') + '/external/github.com/dart-lang/yaml.git' + Var('yaml_dart_revision'),
 
   'src/third_party/pyelftools':
     Var('chromium_git') + '/chromiumos/third_party/pyelftools.git' + '@' + '19b3e610c86fcadb837d252c794cb5e8008826ae',
 
   'src/third_party/breakpad/src':
     Var('chromium_git') + '/external/google-breakpad/src.git' + '@' + '242fb9a38db6ba534b1f7daa341dd4d79171658b', # from svn revision 1471
 
   'src/third_party/lss':
     Var('chromium_git') + '/external/linux-syscall-support/lss.git' + '@' + Var('lss_revision'),
 }
@@ skipping 162 matching lines @@
   # Pull the prebuilt network service binaries according to
   # mojo/public/tools/NETWORK_SERVICE_VERSION.
   {
     'name': 'download_network_service',
     'pattern': '',
     'action': [ 'python',
                 'src/mojo/public/tools/download_network_service.py',
                 '--tools-directory', '../../../tools',
     ],
   },
-  # Run "pub get" on any directories with checked-in pubspec.yaml files
-  # (excluding sky/, whose pubspec.yaml files are not intended for supporting
-  # building in-place in the repo).
-  {
-    'name': 'run_dart_pub_get',
-    'pattern': '',
-    'action': [ 'python',
-                'src/mojo/public/tools/git/dart_pub_get.py',
-                '--repository-root', '../../../..',
-                '--dart-sdk-directory',
-                '../../../../third_party/dart-sdk/dart-sdk',
-                '--dirs-to-ignore', 'sky/',
-    ],
-  },
   {
     # Ensure that we don't accidentally reference any .pyc files whose
     # corresponding .py files have already been deleted.
     'name': 'remove_stale_pyc_files',
     'pattern': 'src/tools/.*\\.py',
     'action': [
         'python',
         'src/tools/remove_stale_pyc_files.py',
         'src/tools',
     ],
@@ skipping 70 matching lines @@
     'name': 'prediction_resources',
     'pattern': '',
     'action': [ 'download_from_google_storage',
                 '--no_resume',
                 '--no_auth',
                 '--bucket', 'mojo/prediction',
                 '-d', 'src/services/prediction/res',
     ],
   },
 ]