Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 1346753002: Implement CheckedNumeric::UnsignedAbs() (Closed)

Created:
5 years, 3 months ago by jschuh
Modified:
5 years, 3 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement CheckedNumeric::UnsignedAbs() This covers some corner cases where we want an equivalent to std::abs() for signed integers, but we want it to convert to an unsigned type of the same width and properly handle the value of signed min(). Committed: https://crrev.com/eaf375f8db272522afff267fe92fa6b27012a78f Cr-Commit-Position: refs/heads/master@{#349300}

Patch Set 1 #

Patch Set 2 : nits #

Total comments: 1

Patch Set 3 : comments #

Patch Set 4 : gcc/glang build fix #

Patch Set 5 : gcc build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
M base/numerics/safe_math.h View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M base/numerics/safe_math_impl.h View 1 2 3 2 chunks +40 lines, -1 line 0 comments Download
M base/numerics/safe_numerics_unittest.cc View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Jeffrey Yasskin
lgtm, or at least, I don't see the problems. https://codereview.chromium.org/1346753002/diff/20001/base/numerics/safe_math_impl.h File base/numerics/safe_math_impl.h (right): https://codereview.chromium.org/1346753002/diff/20001/base/numerics/safe_math_impl.h#newcode327 base/numerics/safe_math_impl.h:327: ...
5 years, 3 months ago (2015-09-15 23:58:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346753002/40001
5 years, 3 months ago (2015-09-16 16:01:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_android/builds/54839)
5 years, 3 months ago (2015-09-16 16:16:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346753002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346753002/80001
5 years, 3 months ago (2015-09-16 19:41:54 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/98713) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-16 20:06:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346753002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346753002/100001
5 years, 3 months ago (2015-09-16 22:14:23 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 3 months ago (2015-09-17 01:04:34 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 01:05:12 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/eaf375f8db272522afff267fe92fa6b27012a78f
Cr-Commit-Position: refs/heads/master@{#349300}

Powered by Google App Engine
This is Rietveld 408576698