Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1346733004: Include transform origin in the transform tree. (Closed)

Created:
5 years, 3 months ago by jbroman
Modified:
5 years, 3 months ago
Reviewers:
pdr.
CC:
blink-reviews, Rik, danakj, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Include transform origin in the transform tree. BUG=460986 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -5 lines) Patch
M Source/platform/geometry/FloatPoint3D.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/platform/graphics/paint/DisplayItemPropertyTreeBuilder.cpp View 3 chunks +6 lines, -1 line 0 comments Download
M Source/platform/graphics/paint/DisplayItemPropertyTreeBuilderTest.cpp View 1 chunk +23 lines, -0 lines 0 comments Download
M Source/platform/graphics/paint/DisplayItemTransformTree.h View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/platform/graphics/paint/DisplayItemTransformTree.cpp View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebDisplayItemTransformTree.h View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jbroman
This takes the origin point from BeginTransform3DDisplayItem and plumbs it into the DisplayItemTransformTree.
5 years, 3 months ago (2015-09-18 19:33:08 UTC) #2
pdr.
LGTM
5 years, 3 months ago (2015-09-18 20:04:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346733004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346733004/1
5 years, 3 months ago (2015-09-19 02:37:34 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-19 02:42:05 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202561

Powered by Google App Engine
This is Rietveld 408576698