Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Unified Diff: Source/modules/accessibility/AXLayoutObject.cpp

Issue 1346733002: Added layout test for aria-orientation and cleaned up code. Also exposed hr element with an orienta… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added TableRole back with a TODO to fix the relevant bug. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXLayoutObject.h ('k') | Source/modules/accessibility/AXNodeObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXLayoutObject.cpp
diff --git a/Source/modules/accessibility/AXLayoutObject.cpp b/Source/modules/accessibility/AXLayoutObject.cpp
index 6506ed1826b7d71bbd889e361a4fa79becbe5311..0b2f1b7ca6d723b65499b64ac8e00184e1b7ab37 100644
--- a/Source/modules/accessibility/AXLayoutObject.cpp
+++ b/Source/modules/accessibility/AXLayoutObject.cpp
@@ -842,49 +842,6 @@ float AXLayoutObject::fontSize() const
return style->computedFontSize();
}
-AccessibilityOrientation AXLayoutObject::orientation() const
-{
- const AtomicString& ariaOrientation = getAttribute(aria_orientationAttr);
- AccessibilityOrientation axorientation = AccessibilityOrientationUndefined;
-
- // For TreeGridRole, roleValue() can't be compared because its overridden
- // in AXTable::roleValue()
- if (ariaRoleAttribute() == TreeGridRole) {
- if (equalIgnoringCase(ariaOrientation, "horizontal"))
- axorientation = AccessibilityOrientationHorizontal;
- if (equalIgnoringCase(ariaOrientation, "vertical"))
- axorientation = AccessibilityOrientationVertical;
- return axorientation;
- }
-
- switch (roleValue()) {
- case ComboBoxRole:
- case ListBoxRole:
- case MenuRole:
- case ScrollBarRole:
- case TreeRole:
- axorientation = AccessibilityOrientationVertical;
- break;
- case MenuBarRole:
- case SliderRole:
- case SplitterRole:
- case TabListRole:
- case ToolbarRole:
- axorientation = AccessibilityOrientationHorizontal;
- break;
- case RadioGroupRole:
- break;
- default:
- return AXObject::orientation();
- }
-
- if (equalIgnoringCase(ariaOrientation, "horizontal"))
- axorientation = AccessibilityOrientationHorizontal;
- if (equalIgnoringCase(ariaOrientation, "vertical"))
- axorientation = AccessibilityOrientationVertical;
- return axorientation;
-}
-
String AXLayoutObject::text() const
{
if (isPasswordFieldAndShouldHideValue()) {
« no previous file with comments | « Source/modules/accessibility/AXLayoutObject.h ('k') | Source/modules/accessibility/AXNodeObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698