Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Side by Side Diff: Source/modules/accessibility/AXObject.cpp

Issue 1346733002: Added layout test for aria-orientation and cleaned up code. Also exposed hr element with an orienta… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added TableRole back with a TODO to fix the relevant bug. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/accessibility/AXNodeObject.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 673 matching lines...) Expand 10 before | Expand all | Expand 10 after
684 AXObjectVector tmpNameObjects; 684 AXObjectVector tmpNameObjects;
685 return textAlternative(false, false, visited, tmpNameFrom, &tmpNameObjects, nameSources); 685 return textAlternative(false, false, visited, tmpNameFrom, &tmpNameObjects, nameSources);
686 } 686 }
687 687
688 String AXObject::recursiveTextAlternative(const AXObject& axObj, bool inAriaLabe lledByTraversal, AXObjectSet& visited) 688 String AXObject::recursiveTextAlternative(const AXObject& axObj, bool inAriaLabe lledByTraversal, AXObjectSet& visited)
689 { 689 {
690 AXNameFrom tmpNameFrom; 690 AXNameFrom tmpNameFrom;
691 return axObj.textAlternative(true, inAriaLabelledByTraversal, visited, tmpNa meFrom, nullptr, nullptr); 691 return axObj.textAlternative(true, inAriaLabelledByTraversal, visited, tmpNa meFrom, nullptr, nullptr);
692 } 692 }
693 693
694 // In ARIA 1.1, the default value for aria-orientation changed from horizontal t o undefined.
695 AccessibilityOrientation AXObject::orientation() const 694 AccessibilityOrientation AXObject::orientation() const
696 { 695 {
696 // In ARIA 1.1, the default value for aria-orientation changed from
697 // horizontal to undefined.
697 return AccessibilityOrientationUndefined; 698 return AccessibilityOrientationUndefined;
698 } 699 }
699 700
700 static String queryString(WebLocalizedString::Name name) 701 static String queryString(WebLocalizedString::Name name)
701 { 702 {
702 return Locale::defaultLocale().queryString(name); 703 return Locale::defaultLocale().queryString(name);
703 } 704 }
704 705
705 String AXObject::actionVerb() const 706 String AXObject::actionVerb() const
706 { 707 {
(...skipping 794 matching lines...) Expand 10 before | Expand all | Expand 10 after
1501 1502
1502 DEFINE_TRACE(AXObject) 1503 DEFINE_TRACE(AXObject)
1503 { 1504 {
1504 visitor->trace(m_children); 1505 visitor->trace(m_children);
1505 visitor->trace(m_parent); 1506 visitor->trace(m_parent);
1506 visitor->trace(m_cachedLiveRegionRoot); 1507 visitor->trace(m_cachedLiveRegionRoot);
1507 visitor->trace(m_axObjectCache); 1508 visitor->trace(m_axObjectCache);
1508 } 1509 }
1509 1510
1510 } // namespace blink 1511 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/accessibility/AXNodeObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698