Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 1346723002: Fix operand lookup in functions to check if local index out of range. (Closed)

Created:
5 years, 3 months ago by Karl
Modified:
5 years, 3 months ago
Reviewers:
Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix formatting. #

Total comments: 2

Patch Set 3 : Fix nit in last patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -14 lines) Patch
M src/PNaClTranslator.cpp View 1 2 2 chunks +13 lines, -8 lines 0 comments Download
A + tests_lit/parse_errs/Inputs/fcn-value-index-isnt-defined.tbc View 2 chunks +11 lines, -6 lines 0 comments Download
A tests_lit/parse_errs/fcn-value-index-isnt-defined.test View 1 2 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Karl
5 years, 3 months ago (2015-09-16 17:45:31 UTC) #2
Jim Stichnoth
lgtm https://codereview.chromium.org/1346723002/diff/20001/src/PNaClTranslator.cpp File src/PNaClTranslator.cpp (right): https://codereview.chromium.org/1346723002/diff/20001/src/PNaClTranslator.cpp#newcode2006 src/PNaClTranslator.cpp:2006: Ice::Operand *reportGetOperandUndefined(NaClBcIndexSize_t Index); Seems a little odd not ...
5 years, 3 months ago (2015-09-16 19:57:41 UTC) #3
Karl
Committed patchset #3 (id:40001) manually as 9d25e620644e1800e381c5c4310a4c79a73a7650 (presubmit successful).
5 years, 3 months ago (2015-09-16 20:47:06 UTC) #4
Karl
5 years, 3 months ago (2015-09-16 20:47:29 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/1346723002/diff/20001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1346723002/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:2006: Ice::Operand
*reportGetOperandUndefined(NaClBcIndexSize_t Index);
On 2015/09/16 19:57:41, stichnot wrote:
> Seems a little odd not to just provide the definition right here?

Done.

Powered by Google App Engine
This is Rietveld 408576698