Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: content/public/browser/web_contents_observer.h

Issue 13467038: Browser Plugin: Expose frame name changes to the content API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Expose RenderViewHost::SetName to the content API Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents_observer.h
diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h
index e0bd1ae7ef5816dfa7bdec1ff21efcabaf1debee..7ebd7bef521b8cf8a1d389d55e1c88654bebb357 100644
--- a/content/public/browser/web_contents_observer.h
+++ b/content/public/browser/web_contents_observer.h
@@ -137,6 +137,11 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,
const LoadCommittedDetails& details,
const FrameNavigateParams& params) {}
+ virtual void DidUpdateFrameName(int frame_id,
jam 2013/04/09 16:11:51 nit: all the methods here are documented. please f
+ bool is_top_level,
+ const std::string& name,
+ RenderViewHost* render_view_host) {}
jam 2013/04/09 16:11:51 seems this should match the order of WCImpl
+
// This method is invoked once the window.document object was created.
virtual void DocumentAvailableInMainFrame() {}

Powered by Google App Engine
This is Rietveld 408576698