Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

Issue 1346673003: Allow text expectation for reftests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
index 2b80260d1589505d58a950f53e422cd3a48af5d8..87d2df0e88829d9c576b54f74fb7a55af46bb297 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
@@ -220,16 +220,19 @@ class RebaselineTest(BaseInternalRebaselineCommand):
target_baseline, baseline_directory, test_name, suffix)
def _rebaseline_test_and_update_expectations(self, options):
+ self._baseline_suffix_list = options.suffixes.split(',')
+
port = self._tool.port_factory.get_from_builder_name(options.builder)
- if (port.reference_files(options.test)):
- _log.warning("Cannot rebaseline reftest: %s", options.test)
- return
+ if port.reference_files(options.test):
+ if 'png' in self._baseline_suffix_list:
+ _log.warning("Cannot rebaseline image result for reftest: %s", options.test)
+ return
+ assert self._baseline_suffix_list == ['txt']
if options.results_directory:
results_url = 'file://' + options.results_directory
else:
results_url = self._results_url(options.builder)
- self._baseline_suffix_list = options.suffixes.split(',')
for suffix in self._baseline_suffix_list:
self._rebaseline_test(options.builder, options.test, suffix, results_url)

Powered by Google App Engine
This is Rietveld 408576698