third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py - Issue 1346673003: Allow text expectation for reftests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py

Issue 1346673003: Allow text expectation for reftests (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py

index 2534fda6fd7a6920e9f6fab9ebcf2f6405f27f95..7b5fc84eb9a97ed4f0b472bbb457122152bd4997 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py

@@ -68,13 +68,14 @@ def determine_result_type(failure_list):

is_text_failure = (FailureTextMismatch in failure_types or

FailureTestHarnessAssertion in failure_types)

is_image_failure = (FailureImageHashIncorrect in failure_types or

- FailureImageHashMismatch in failure_types)

+ FailureImageHashMismatch in failure_types or

+ is_reftest_failure(failure_list))

is_audio_failure = (FailureAudioMismatch in failure_types)

if is_text_failure and is_image_failure:

return test_expectations.IMAGE_PLUS_TEXT

elif is_text_failure:

return test_expectations.TEXT

- elif is_image_failure or is_reftest_failure(failure_list):

+ elif is_image_failure:

return test_expectations.IMAGE

elif is_audio_failure:

return test_expectations.AUDIO