Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py

Issue 1346673003: Allow text expectation for reftests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py
index 2534fda6fd7a6920e9f6fab9ebcf2f6405f27f95..7b5fc84eb9a97ed4f0b472bbb457122152bd4997 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py
@@ -68,13 +68,14 @@ def determine_result_type(failure_list):
is_text_failure = (FailureTextMismatch in failure_types or
FailureTestHarnessAssertion in failure_types)
is_image_failure = (FailureImageHashIncorrect in failure_types or
- FailureImageHashMismatch in failure_types)
+ FailureImageHashMismatch in failure_types or
+ is_reftest_failure(failure_list))
is_audio_failure = (FailureAudioMismatch in failure_types)
if is_text_failure and is_image_failure:
return test_expectations.IMAGE_PLUS_TEXT
elif is_text_failure:
return test_expectations.TEXT
- elif is_image_failure or is_reftest_failure(failure_list):
+ elif is_image_failure:
return test_expectations.IMAGE
elif is_audio_failure:
return test_expectations.AUDIO

Powered by Google App Engine
This is Rietveld 408576698